search

Codeception / robo-paracept

Robo tasks for Codeception tests parallel execution
MIT License
57 stars 59 forks source link

"Return value must be of type Codeception\Task\Splitter\TestFileSplitterTask" when splitting the tests after upgrading to version 1.0 #62

Closed ccsuperstar closed 3 years ago

ccsuperstar commented 3 years ago

After updating the robo-paracept version, and making the changes indicated in the readme, I get this error when I run the split command PHP Fatal error: Uncaught TypeError: RoboFile::taskSplitTestFilesByGroups(): Return value must be of type Codeception\Task\Splitter\TestFileSplitterTask, Robo\Collection\CollectionBuilder returned in /vendor/codeception/robo-paracept/src/Splitter/TestsSplitterTrait.php:26

DavertMik commented 3 years ago

@vansari could you help with this?

vansari commented 3 years ago

Yes of course. I will do it tomorrow evening. @DavertMik

vansari commented 3 years ago

Hi @ccsuperstar

can you please check the fix? I think the return type was not correct :-)

I forgot to use the union type

ccsuperstar commented 3 years ago

It's ok now on splitting tests, thanks!

ccsuperstar commented 3 years ago

Could you tell me how to use the GroupFilter for tests failed?

vansari commented 3 years ago

Hi @ccsuperstar

Could you please open a new issue for this question? I think this would be a new feature.

Please let us know what you want to do.

Bye 👋

ccsuperstar commented 3 years ago

Ok I'll do it!

ccsuperstar commented 3 years ago

I can make a PR with my previous code if you want

vansari commented 3 years ago

Hi @ccsuperstar

I think this issue can be closed?!

ccsuperstar commented 3 years ago

Yes!