search

Codectory / AutoActions

Application-based actions to change Windows settings ( display, audio) or run any program or action
GNU General Public License v3.0
486 stars 18 forks source link

Closed Actions not working #38

Closed 1joeljohnson closed 2 years ago

1joeljohnson commented 2 years ago

I set an App Start Action to change resolution to 3840X1620 and activate HDR on launch of a UWP app. I then set an App Closed Action to try and deactivate the HDR and set resolution back to 3840X2160. When launched HDR gets activated and resolution changed; however, when application is closed the HDR does not get deactivated and the resolution does not change back to 3840X2160. autohdrProfile

Attaching log file as well.

Thank AutoHDR.log s

Codectory commented 2 years ago

Could you please send me you UserSettings.xml?

1joeljohnson commented 2 years ago

UserSettings.txt Here you go.
Thank you for the quick response. I love this application. I bought you a beer.

Codectory commented 2 years ago

Thanks for the beer 👍

Codectory commented 2 years ago

Alright, there are some bad things I have done with the UserSettings, a I have to clean this up.

1joeljohnson commented 2 years ago

I'm glad you were able to identify the issue/issues.

Let me know if there is anything I can help test.

Codectory commented 2 years ago

Could you try this with the newest release ?

1joeljohnson commented 2 years ago

Absolutely.

kyotocafe commented 2 years ago

With the new version, 1.7.2 , the resolution is changing when the application is closed, however HDR does not get deactivated. Same with the got focus actions, I am testing it like this. Notepad launches when the application loses focus, but HDR is still on.

image

Codectory commented 2 years ago

Could you show me your settings file?

kyotocafe @.***> schrieb am Fr. 26. Nov. 2021 um 21:47:

With the new version, 1.7.2 , the resolution is changing when the application is closed, however HDR does not get deactivated.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Codectory/AutoHDR/issues/38#issuecomment-980429795, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWXFIKP7HNBVTAXC6EQZHLUN7W5FANCNFSM5IWRAPOA .

kyotocafe commented 2 years ago

Sure, thanks for checking into this, this is my settings file, UserSettings.xml.txt

Codectory commented 2 years ago

Did created an application closed action to disable hdr?

kyotocafe @.***> schrieb am Fr. 26. Nov. 2021 um 21:51:

Sure, thanks for checking into this, this is my settings file, UserSettings.xml.txt https://github.com/Codectory/AutoHDR/files/7610661/UserSettings.xml.txt

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Codectory/AutoHDR/issues/38#issuecomment-980430974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWXFIJYQLREYV5CFN3BH63UN7XMHANCNFSM5IWRAPOA .

kyotocafe commented 2 years ago

I did try it, but it was the same behaviour as the lost focus actions.

Codectory commented 2 years ago

Are you able to toggle HDR with the button on the first page?

kyotocafe @.***> schrieb am Fr. 26. Nov. 2021 um 22:15:

I did try it, but it was the same behaviour as the lost focus actions.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Codectory/AutoHDR/issues/38#issuecomment-980437711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWXFIP7WXCRBZGIBGPFJNDUN72GBANCNFSM5IWRAPOA .

kyotocafe commented 2 years ago

Yes, that works fine , it toggles HDR on and off.

1joeljohnson commented 2 years ago

Could you try this with the newest release ?

This is still not working for me. When launching Halo Infinite, HDR gets activated and resolution changed to 3840x1620 and when exiting the game, HDR doesnt get deactivated and resolution does not change to 3840x2160. UserSettings - Copy.xml.txt

Codectory commented 2 years ago

Should be fixed in 1.7.3

1joeljohnson commented 2 years ago

Should be fixed in 1.7.3

I'm sorry but this seemed to have broken a few things. So HDR gets activated and when I launch the application and then it will deactivate HDR when the app is loaded. Confirmed by my screens settings that HDR got deactivated. UserSettings - Copy.xml.txt vated.
Also, the resolution still will not change back to 3840x2160 from being changed to 3840x162.

1joeljohnson commented 2 years ago

Also, I just noticed that if you delete your user settings file in the autoHDR folder, it will not write a new file.

1joeljohnson commented 2 years ago

Finally got the new json settings to write to folder. Resolution was to install version 1.7.2, launch it, close it, and then overwrite that with 1.74. I can now see the user settings json file.

However, issues still stand with HDR getting deactivated after launch and resolution not changing back after app is closed. AutoHDR.log

UserSettings - Copy.json.txt

Codectory commented 2 years ago

Can you try to run the app with admin rights?

1joeljohnson commented 2 years ago

Can you try to run the app with admin rights?

Just tried and same results. HDR gets turned on, religion changes, then HDR gets deactivated when the game is loading. Then when I exit the game, resolution does not change back.

Codectory commented 2 years ago

Alright, so the game uses a launcher and this launcher starts the game process and closes afterwards. AutoHDR works correctly but is monitoring the wrong process. Can you try another game?

Joel @.***> schrieb am Do. 2. Dez. 2021 um 13:35:

Can you try to run the app with admin rights?

Just tied and same results. HDR gets turned on, religion changes, then HDR gets deactivated when the game is loading. Then when I exit the game, resolution does not change back.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Codectory/AutoHDR/issues/38#issuecomment-984588158, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWXFIO4IHH6I35VCO23QPLUO5RZJANCNFSM5IWRAPOA .

1joeljohnson commented 2 years ago

I tried another game and HDR seems to work but the resolution will still not change back after the app is closed.

kyotocafe commented 2 years ago

It is working fine now for me, thanks!

1joeljohnson commented 2 years ago

Another new behavior is that HDR will activate but my resolution will not change for the game I launch. If I alt tab out I can see my desktop resolution and aspect ratio changed but not the game.

Maybe my use cases don't play well with these features.

Codectory commented 2 years ago

The game needs to use the system resolution. If the resolution gets overwritten in the game settings, AutoHDR can do nothing.

Joel @.***> schrieb am Fr. 3. Dez. 2021 um 00:39:

Another new behavior is that HDR will activate but my resolution will not change for the game I launch. If I alt tab out I can see my desktop resolution and aspect ratio changed but not the game.

Maybe my use cases don't play well with these features.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Codectory/AutoHDR/issues/38#issuecomment-985089736, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWXFIJA2MG2LDKUOHSYFQTUO77S5ANCNFSM5IWRAPOA .