search

CodeforAustralia / rerouteit

Code For Australia's version of the US ReRoute It transport choices application
MIT License
5 stars 0 forks source link

Style enforcement and CI #15

Closed ghost closed 10 years ago

ghost commented 10 years ago

I'd recommend that you guys setup a style guide and lean on something like https://houndci.com for enforcing style, as I can already see in #14 inconsistencies in spacing, " and ' etc

I'd also recommend using like https://travis-ci.org for CI. Both of these services are free for open source.

Lastly, http://codeclimate.com/ is amazing and is also free for open source.

ghost commented 10 years ago

I'll try and send a PR for this tonight.

cdaloisio commented 10 years ago

:+1:

ghost commented 10 years ago

https://codeclimate.com/github/CodeforAustralia/rerouteit can be setup without additional permissions, but Travis and Hound need collaborator access.

@cdaloisio can you set them up?

ghost commented 10 years ago

Dependency Status

Code Climate

Test Coverage

ghost commented 10 years ago

I've added the badges based on conventions, but obviously Travis isn't hooked up properly as I don't have access.

ghost commented 10 years ago

@cdaloisio Travis will need to be setup by a collaborator. CodeClimate also requires a collaborator for test coverage.

cdaloisio commented 10 years ago

@Soliah Not a problem, I've set these up. Should be good to go. There is just an issue with the first build which I'll get sorted soon. I'm just going through #14 to split it into separate pull requests and make a few adjustments

ghost commented 10 years ago

@cdaloisio ah we need to also do a bundle exec rake db:create in the before_script section of the travis.yml

cdaloisio commented 10 years ago

Yep, just about to add it :+1: