Get basic UI working and refactor transport modes

CodeforAustralia / rerouteit

Code For Australia's version of the US ReRoute It transport choices application

MIT License

5 stars 0 forks source link

Get basic UI working and refactor transport modes #24

Closed ghost closed 6 years ago

ghost commented 9 years ago

Bunch of stuff in this PR that I'd appreciate review on.

This was a bit rushed but I've done the following:

Update Rails
Update other gems
Removed Angular from the manifest
Refactored the transport modes into actual database models
Got basic UI working with just some jQuery
Setup puma for Heroku

You can test it out here: https://rerouteit.herokuapp.com/

I've still got to write the tests for the TripService.

coveralls commented 9 years ago

Coverage decreased (-33.33%) when pulling 3c42e3d2bcfa23d0f112ce2e8e74437091a2754e on feature/get-basic-ui-working into cae339e8330950316a9fca8be330deaf9c77edec on develop.

coveralls commented 9 years ago

Coverage decreased (-33.33%) when pulling 3c42e3d2bcfa23d0f112ce2e8e74437091a2754e on feature/get-basic-ui-working into cae339e8330950316a9fca8be330deaf9c77edec on develop.

ghost commented 9 years ago

To test this branch locally you'll need to setup the database: rake db:migrate db:seed.

cdaloisio commented 9 years ago

Thanks @Soliah! It's been a hectic end to the year but I'll be going through this shortly, thanks for your contributions! :smile:

coveralls commented 9 years ago

Coverage decreased (-33.33%) when pulling c9c18ceabac3ed324932bec0c90066857029b38d on feature/get-basic-ui-working into cae339e8330950316a9fca8be330deaf9c77edec on develop.

coveralls commented 9 years ago

Coverage decreased (-33.33%) when pulling c26f2c75e46c10efce4fbb17d1bfba1b6e633ce9 on feature/get-basic-ui-working into cae339e8330950316a9fca8be330deaf9c77edec on develop.

cdaloisio commented 9 years ago

Happy New Year @Soliah! Apologies for the delay, it has been a hectic break :smile:

Looks good, the only thing I would say is to perhaps convert the JS to coffee-script because the coffee-rails gem installed

I'll be merging this early in the week and working on implementing the other remaining methods of cost and calories

coveralls commented 9 years ago

Coverage decreased (-33.33%) when pulling 5e8205cfbce125bd7ae49de7429fd219927e529a on feature/get-basic-ui-working into cae339e8330950316a9fca8be330deaf9c77edec on develop.

coveralls commented 9 years ago

Coverage decreased (-33.33%) when pulling 5e8205cfbce125bd7ae49de7429fd219927e529a on feature/get-basic-ui-working into cae339e8330950316a9fca8be330deaf9c77edec on develop.

ghost commented 9 years ago

looks good .. there are a few things i would do differently. But the important thing that it works and validations in place. @Soliah good job.

ghost commented 9 years ago

@arvindcj thanks. This was more just to get something working and the project moving a bit.