search

CodeforAustralia / school-finder

:eyes: Find schools by location
https://education.nsw.gov.au/school-finder
GNU General Public License v3.0
18 stars 7 forks source link

Reset app state on new searches #264

Closed reekypete closed 7 years ago

reekypete commented 7 years ago

If user scrolls back to top to start a new search, various state elements are not refreshed. E.g. if the first search was for a Primary school, and the second for a Secondary school, the catchment won't show.

Update:

For example: if a user specifies an address, this drops a "my location" pin. If the user then scrolls up and searches for a school-name, the "my location" pin is left on the page and skews the rendering.

Rustum has asked that new requests should start with a clean state - do not save addresses or levels or geocodes between requests.

techieshark commented 7 years ago

Closing - this is a duplicate of #254. Feel free to reopen and change description if there's something else other than catchments not showing.

reekypete commented 7 years ago

For example: if a user specifies an address, this drops a "my location" pin. If the user then scrolls up and searches for a school-name, the "my location" pin is left on the page and skews the rendering.

Rustum has asked that new requests should start with a clean state - do not save addresses or levels or geocodes between requests.

Rustuma commented 7 years ago

Whether it's #254 or #264 - can we please clear the fields between requests. The system has been tested by several (new) users in the past week and it was noted that we seem to 'retain' addresses. We specifically said that we wouldn't in the supporting documentation and in the app - "The School Finder asks for your home address to provide the most accurate information about your local school. The tool does not store your address, with the information discarded immediately after you complete your search."

techieshark commented 7 years ago

OK, re-opening as this is a different issue than #254.

techieshark commented 7 years ago

@Rustuma points out another facet of this issue: https://github.com/CodeforAustralia/school-finder/pull/287#issuecomment-263168458