CodeforAustralia / school-finder

:eyes: Find schools by location
https://education.nsw.gov.au/school-finder
GNU General Public License v3.0
17 stars 7 forks source link

Fixes/264 scrolling up should reset search state #265

Closed reekypete closed 7 years ago

reekypete commented 7 years ago

Basically implemented a "reset-in-code" model for app state.

I've attached this mostly to the search buttons (since scrolling up isn't reliable enough to reset state)

I.e. when a user click search, reset state before doing anything.

The only exception is app.level, which gets set by the "Primary" & "Secondary" buttons. I reset this when a school is searched by name

techieshark commented 7 years ago

See comment on #264. If this is still an issue, please reopen that and also use git rebase -i master on this branch to remove unrelated commit (fixes/262...) and squash very related commits 925b3ae and 5fbeefc into one (see this comment for details on git rebase).

Thanks!

techieshark commented 7 years ago

Incorporated into #297, thanks!