CodeforAustralia / school-finder

:eyes: Find schools by location
https://education.nsw.gov.au/school-finder
GNU General Public License v3.0
18 stars 7 forks source link

Perhaps unintentional removal of info on how to seek support #282

Closed techieshark closed 7 years ago

techieshark commented 7 years ago

I just noticed that we inadvertently (I assume) removed some text that explained how to get special learning needs support.

@Lilith-Palmer previously reported that parents seeking special learning needs support for their child should go through their local school:

The most crucial piece of information to come out of this research was that, in all cases, parents with children that require special learning needs support should begin the process of finding an appropriate school with the Principal of their local, catchment school.

I then asked if we should make the following change, from this:

screen shot 2015-10-16; shows specific types of support offered at a school

to this:

screen shot 2015-10-16; specific types of support offered at the school have been removed but it still instructs the user to contact the school to learn how to get support

Lilith agreed.

Commit 87afdde06e786bac7063dea680d92346c8da0231 made the suggested change, but shortly after it appears to have been wiped out by commit 907c487c79eba594234f39a8b1cae694b86b0175. Note the roll-back effect on line 288. That commit's message doesn't mention intentionally removing the effect of the previous commit, so it may have just been some kind of unintended merging problem.

Lilith-Palmer commented 7 years ago

Agreed - not sure how this was removed but needs to be reinstated. @reekypete @Rustuma anything to add?

techieshark commented 7 years ago

@Lilith-Palmer do you recall what that section was supposed to look like for SSPs? Is it right that those have specific special learning needs support that we should highlight in that section?

When I search for Royal Prince Alfred school, I see this right now (with the current fix that brings back this section).

image

Sidenote: that school has an enrolment of zero -- is that right? Other SSPs don't.

Lilith-Palmer commented 7 years ago

@techieshark Yes, as above is correct. Re the 0 enrolment - that's ok, hospital schools often have no enrolments as most students attend for a shorter period whilst remaining enrolled at their local school.

techieshark commented 7 years ago

Cool thanks @Lilith-Palmer.

Rustuma commented 7 years ago

@techieshark - That's a good pickup. I think it was an unintentional removal. But are we going to add the note in on all schools or just SSPs?

techieshark commented 7 years ago

@Rustuma thanks (yeah, I found it accidentally while reviewing csslint output actually.)

I think the note should be on all schools (we put it there instead of trying to help people find schools with particular supports, since -- my understanding -- is that any normal school can sometimes change what accommodation it provides.

Perhaps for SSPs, we should just leave this section off? Presumably, the entire "About" school description explains in detail the special support offered by the school; for example, here's the first two lines from Wairoa School's description:

Wairoa School provides educational programs for students with moderate to high support needs. Our programs support students with a moderate to severe intellectual disability, who may also have additional support needs related to autism, physical and/or sensory disabilities.

Rustuma commented 7 years ago

image If we are going to add it to all schools then what about: "Contact your local school" instead of "Contact this school". It's a subtle change but emphasizes that all schools may be able to provide support

techieshark commented 7 years ago

👍 for the logic behind "Contact your local school" (normally people should just inquire at their local school), but presumably their local school would be the first school we'd normally direct them to, and they'd only be looking at this (other) school if they had some other reason for thinking about going to it - so maybe we want to keep it as "contact this school"?

Also, maybe actually it doesn't hurt to just keep it there on the SSPs? To imply that yes, they can still ask the school for more info just like at any other school? No need to over-complicate things right?

Rustuma commented 7 years ago

Done. Make it so number 1

Lilith-Palmer commented 7 years ago

@techieshark The link to general support overview: support opens in the same window - should be a new tab (as per other links)