CodeforAustralia / school-finder

:eyes: Find schools by location
https://education.nsw.gov.au/school-finder
GNU General Public License v3.0
18 stars 7 forks source link

Fixes linter issues #287

Closed techieshark closed 7 years ago

techieshark commented 7 years ago

Fixes #286 (and related to #272).

These commits

There's a lot of small changes (whitespace, etc) that should be easy to see are innocuous, and the biggest changes are related to console.log -- we now use app.util.log() everywhere instead, and provide a polyfill for IE 9 and below to ensure we don't get errors from a nonexistent console object. Console logging can be turned off by setting app.debug to false in config.js.

Note: commits emoji exact meanings are described here: https://gitmoji.carloscuesta.me/

Rustuma commented 7 years ago

Workflow:

  1. Searched by address for a Primary School (Address in Cherrybrook)
  2. Returned result - all worked well (Same for Secondary)
  3. Clicked "Scroll to top" (a new feature??)
  4. Entered a school name (Ferncourt in Marrickville)
  5. New school shown - but had old address on bottom: image

When searching by School Name this section should not be shown: image

Rustuma commented 7 years ago

This error is in current Master as well. It never used to be there.

Rustuma commented 7 years ago

OK. So if the reset app state issue is being addressed in another PR then this one of good to go. Merge!

techieshark commented 7 years ago

Sweet, thanks!