CodeforAustralia / school-finder

:eyes: Find schools by location
https://education.nsw.gov.au/school-finder
GNU General Public License v3.0
17 stars 7 forks source link

school info text "this school serves your location" can be wrong #295

Closed techieshark closed 7 years ago

techieshark commented 7 years ago

@Rustuma pointed out that the school info text saying "this school serves your location" can be wrong (relates to #264 but won't be completely fixed by that).

When searching by School Name this section should not be shown:

image

If I recall correctly, the intent was to confirm to users that we're showing this school because it serves the home address they searched for. If you search for "123 Some Street", you should see this beneath the other info for a school (in the section below the map):

This school serves your location (123 Some Street, Somewhere NSW 1984, Australia). Please contact the school if you require more information about the local enrolment area.

However, here are some cases where this can be wrong:

  1. The example Rustum pointed out, where you search by address, scroll to the top, then search by school name.

  2. If you search by an address, click "Show nearby schools", then click any of the nearby schools.

  3. If you search by an address not inside any catchment area (either directly or by dragging the home marker). For example, try finding a primary school for "Mount Lambie, New South Wales" (just south of Portland and west of Lithgow). In this case, there are a handful of nearby schools that should serve you (I think -- but we just show the nearest handful) but the address isn't inside any one school's specific catchment area.


Perhaps we should not try to be too smart, and just have the message say something about the relation between the address searched for and the school's catchment area:

If they searched by address and we're showing a school whose catchment includes their address:

Your location (123 Some Street, Somewhere NSW 1984, Australia) is inside this school's local enrolment area. Please contact the school if you require more information about the local enrolment area.

If they searched for an address and we're showing a school whose catchment doesn't contain their address:

Your location (123 Some Street, Somewhere NSW 1984, Australia) is not inside this school's local enrolment area, but out of area enrolment may be an option, especially if this is one of your closest schools--[I don't know how this part works in remote areas -P]. Please contact the school if you require more information about the local enrolment area.

That would show for neighboring schools in urban areas, as well as the nearest school to a user in some remote areas.

If we don't know the user's address:

Search by address to see if your address is inside this school's enrolment area, and please contact the school if you require more information about the local enrolment area.

Rustuma commented 7 years ago

I like it. Except for: image

Why would this scenario occur? - In my mind it would be an error. Plus don't encourage out of area enrolments by suggesting it in the app. This could place an administrative burden on the schools. The recent battles we have been fighting have been on schools worrying about just such issues.

Rustuma commented 7 years ago

Also - can't we set a Reset function. For example: 1. I searched by address and it worked. 2. I scroll up and search by school. In this case blow away the address field. Is that too hard to program? Let me know

techieshark commented 7 years ago

Why would this scenario occur?

Biggest issue, I think, is if someone lives out in the boonies (aka boondocks aka sticks aka "the bush"?) where the schools either don't have catchments or they live outside any catchment area. In that case, it was my understanding that we just show people nearby schools and they're supposed to pick one.

Rustuma commented 7 years ago

Ah yes. I wonder if we aren't trying too hard. What would happen if we just removed the first sentence and said "Please contact the school if you require more information about the local enrolment area." It's simple but still shows them what to do if they have a question.