distinguish between primary and secondary catchments when both are shown

CodeforAustralia / school-finder

:eyes: Find schools by location

https://education.nsw.gov.au/school-finder

GNU General Public License v3.0

18 stars 7 forks source link

distinguish between primary and secondary catchments when both are shown #56

Closed techieshark closed 8 years ago

techieshark commented 9 years ago

Edge case: there are six community/central schools which have catchment areas (which differ!) for primary and secondary levels, and when we just first search for a school name (without declaring which level we're interested in), a school is shown with funny looking boundaries (because they overlap).

A potential fix is to show the catchment areas with different colors (set different styles via CartoCSS) and add a legend so the users can see what is going on.

techieshark commented 9 years ago

I'm planning to run this issue by @pixelhappy1 to see if she has any design ideas for us.

techieshark commented 9 years ago

No response from @pixelhappy1 yet. Assigning to @Lilith-Palmer to follow up and review this issue.

pixelhappy1 commented 9 years ago

Hey! Different colours could work, but may look strange on the overlap section? (Looking like a 3rd section.) The same colour with borders seems to look ok to me - just need to add the 2nd icon?

techieshark commented 8 years ago

Fixed by this commit: https://github.com/CodeforAustralia/school-finder/commit/907c487c79eba594234f39a8b1cae694b86b0175

It added a legend and some colors. See for example: https://github.com/CodeforAustralia/school-finder/commit/907c487c79eba594234f39a8b1cae694b86b0175#diff-4692250fac55f6006a17d764cb838a55R353