search

CodeforLeipzig / wo-ist-testzentrum

https://wo-ist-testzentrum.de/#leipzig
Other
7 stars 4 forks source link

Fix validation issues #17

Open joergreichert opened 3 years ago

joergreichert commented 3 years ago

Just discovered the validator today: node ./validation/testcenter-validator.js

For Berlin and Hessen there are still some issues (already fixed the issues for Leipzig and Duesseldorf) validation_issues.txt

johnjohndoe commented 3 years ago

Please note that the validation script in the Wo ist Markt? project has been improved lately. You might want to pick the relevant code changes.

joergreichert commented 3 years ago

Synced with https://github.com/wo-ist-markt/wo-ist-markt.github.io
Still validation issues for Berlin and Hessen ouput.txt

johnjohndoe commented 3 years ago

Did you run npm test on the project? There is a bunch of lint warnings which might cause other errors.

I think the project should have automatic CI checks as it is running for the Wo ist Markt? repository. What do you think about this?

joergreichert commented 3 years ago

I've fix the lint issues besides validation/testcenter-validator.js: line 600, col 19, 'URL' is not defined. :+1: for automatic CI checks. So we need to integrate the netlify.toml and the rollup dependency for this, right?

johnjohndoe commented 3 years ago

I addressed the URL issue in #23. With that you should be able to run the updated validation script.

johnjohndoe commented 3 years ago

For automatic checks Wo ist Markt? is using Travis CI. A minimal .travis.yml configuration (copied from here) would be:

language: node_js

node_js: # Read version from .nvmrc

install:
  - npm install

script:
  - npm test
  - npm build

You can of course use any other CI provider such as GitHub Actions.