CodeforLeipzig / wo-ist-testzentrum

https://wo-ist-testzentrum.de/#leipzig
Other
7 stars 4 forks source link

Cities without opening hours #2

Closed ubergesundheit closed 3 years ago

ubergesundheit commented 3 years ago

How should cities without published opening hours be handeled?

Münster already has https://codeformuenster.org/corona-testungen/ but the official page does not publish opening hours.

Any idea how to handle this?

joliyea commented 3 years ago

I simply added 'keine Angabe' like so:

{
    "geometry": {
        "coordinates": [
            "8.536862",
            "50.335011"
        ],
        "type": "Point"
    },
    "properties": {
        "location": "Obergasse 13 61250 Usingen",
        "telephone": "06081 66742",
        "details_url": "keine Angabe",
        "opening_hours": "keine Angabe",
        "title": "Adler Apotheke",
        "hints": [
            "Nur mit telefonische Anmeldung.",
            "PCR-Test: nein",
            "Terminbuchung notwendig: ja"
        ]
    },
    "type": "Feature"
}
joergreichert commented 3 years ago

With "keine Angabe" the marker won't appear on the map in any category ("jetzt", "heute", "alle", "sonstige"). Not sure yet what to set in opening hours to end up in "sonstige". Maybe we need more categories (like appointment only be phone, appointment only online). Even then maybe opening hours needs to be differ between time range, where I'm able to make an appointment (when will be someone on the phone), and time range when I can really go there to do the test.

joliyea commented 3 years ago

Good point. How should it be handled instead?

johnjohndoe commented 3 years ago

Did you try to use the opening_hours_unclassified property as stated in the contribution guide?

Opening hours which cannot be expressed in that format can use the opening_hours_unclassified property. In that case set the opening_hours property to null.

These markers should appear under "Sonstige".

joergreichert commented 3 years ago

Didn't get it working.

joergreichert commented 3 years ago

Ok, finally found my mistake. I was pushing to the wrong remote :relieved: