search

CodeforNepal / nepalmap_app

An application that maps census and other official data for Nepal to make data more easily accessible and understandable to the public. Want to help us? Check out the Wiki.
https://nepalmap.org
MIT License
64 stars 42 forks source link

Add data on Health Facilities #215

Closed Bezzy1999 closed 6 years ago

Bezzy1999 commented 6 years ago

As discussed in https://github.com/Code4Nepal/nepalmap_app/issues/149 this pr adds that data.

Let me know what you think, I ended up abbreviating some of the facility types in health.py due to some overlap issues on displaying the bar chart.

cliftonmcintosh commented 6 years ago

@Bezzy1999

Thank you very much. This is very nice work and will be a great addition to the data.

Before merging, I would like to do a couple of sanity checks by comparing some data on the original data source with the numbers that you have collected.

Bezzy1999 commented 6 years ago

@cliftonmcintosh I have updated the sql with these changes. I'm still concerned that we may be consolidating locations but the data does look more reasonable now,

I'll add the updated script as a new pr in maptools once you're happy.

Let me know what you think.

cliftonmcintosh commented 6 years ago

@Bezzy1999

Thank you for the update. Looking through it, it does seem that the figures are more likely than some of the ones before. I don't really know how to assess whether we might be off or by how much. I am comfortable with the strategy of enforcing uniqueness, and I am comfortable with the data.