search

CodeforNepal / nepalmap_federal

Instance of NepalMap for federal Nepal. Join us!
https://nepalmap.org
MIT License
14 stars 20 forks source link

[ENHANCEMENTS] dsign fixes #102

Closed ishandongol closed 4 years ago

ishandongol commented 4 years ago

Enhancements

cliftonmcintosh commented 4 years ago

@ishandongol

Thank you. It looks much better! One thing I noticed is that the main profile card (the one that goes with the map at the top) is white in a wider screen but matches the grey on the background on a smaller screen. Would we want the tile to be white on smaller devices like it is on a wider screen or is this a deliberate choice to make it feel like it's not sitting on top? Screenshots here:

Wider screen top-tile-wide

Smaller screen top-tile

cliftonmcintosh commented 4 years ago

@ishandongol

When I deployed this to beta.nepalmap.org, the top tile is white. I'm not sure why it didn't display correctly when I ran it on my laptop earlier.

Here is a screenshot of https://beta.nepalmap.org/profiles/district-41-makwanpur/ in desktop Chrome that has been sized down as well as a screenshot from my phone.

white-top-tile Makwanpur

cliftonmcintosh commented 4 years ago

This has been deployed to https://beta.nepalmap.org.

ishandongol commented 4 years ago

We need to compile the sass file. I guess you forgot to run compilescss in local.

Will look further into the issue.

On Sun, Jan 19, 2020, 20:37 Clifton McIntosh notifications@github.com wrote:

This has been deployed to https://beta.nepalmap.org.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Code4Nepal/nepalmap_federal/pull/102?email_source=notifications&email_token=AC3SLA2XD5HHZUO3KSIA353Q6RSJLA5CNFSM4KIY47PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKUATY#issuecomment-576012367, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3SLA7MQW647FDY4SEM2VTQ6RSJLANCNFSM4KIY47PA .