search

CodeforNepal / nepalmap_federal

Instance of NepalMap for federal Nepal. Join us!
https://nepalmap.org
MIT License
14 stars 20 forks source link

Upgrade to caddy v2 #112

Closed suvash closed 2 years ago

suvash commented 4 years ago

Took the time to dig into docs for Caddy v2 and it was simple enough.

However, master seems to be broken for make start from scratch. Took me a while to lock certain versions and get it rolling further, but I still see a lot of warnings in the db import logs.

Also, since the dependencies used by this application is not very clear, I'd recommend using tool like pip-compile to create a full dependency list and freeze it in requirements.txt, esp. given most of the packages use are getting old and new ones get installed by default.

One more thing, I'm not sure of the migration path on keeping the same old certs, because options have changed in caddy on how/where it stores those files.

You should be able to make start on this branch, but I'm not sure what else could be broken.

pratimakandel commented 2 years ago

@suvash Hey, thanks for working on this issue. Is it possible if you could re-submit the PR with the latest master/dev build.

suvash commented 2 years ago

@pratimakandel Ah, I made this PR a long time ago. I don't remember the details in my head anymore. Please feel free to use any interesting parts from it. I'll close it in the meantime.