CodeforNepal / nepalmap_federal

Instance of NepalMap for federal Nepal. Join us!
https://nepalmap.org
MIT License
14 stars 20 forks source link

Correct the parent geo_codes for localities #16

Closed cliftonmcintosh closed 6 years ago

cliftonmcintosh commented 6 years ago

The parent geo_codes for localities appear to be incorrect in https://github.com/Code4Nepal/nepalmap_federal/blob/dev/sql/geography.sql

In spot-checking the data, I have found that the codes for the districts do not match the codes for the muncipalities that should be in each district.

I have based my comparison on personal knowledge of some districts as well as comparison of the data in https://github.com/Code4Nepal/data/tree/master/Federal%20Data/753%20Local%20Unit%20Population%20and%20HouseHold

Examples of discrepancies: Achham is dis-01, but municipalities (like Sunsari) in Achham are listed as belonging to dis-69 Arghakhanchi is dis-02, but Arghakhanchi municipalities are listed as belonging to dis-51 Bhaktapur is dis-10, but Bhaktapur muncipalities are listed as belonging to dis-26 Dadeldhura is dis-13, but Dadeldhura muncipalities are listed as belonging to dis-73

This list is an example. It is not comprehensive. In my spot-checking, I have found no muncipalities with the correct parent code.

ravinepal commented 6 years ago

@cliftonmcintosh - thank you for flagging

@crackjack - may i request you to look into this when you have time

openrijal commented 6 years ago

@ravinepal Sure.

@cliftonmcintosh the error was in the underlying geojson file, which result faulty csv and finally faulty sql

I have fixed the issue and created a pull request in both maptools and nepalmap_federal apps

amitness commented 6 years ago

The pull request for this seems to be merged. Should we close this? @cliftonmcintosh

cliftonmcintosh commented 6 years ago

Yes, @amitness

Closing