CodeforNepal / nepalmap_federal

Instance of NepalMap for federal Nepal. Join us!
https://nepalmap.org
MIT License
14 stars 20 forks source link

Update province names for Gandaki and Karnali provinces #52

Closed cliftonmcintosh closed 5 years ago

cliftonmcintosh commented 5 years ago

As per @ravinepal's comment at https://github.com/Code4Nepal/nepalmap_federal/issues/22#issuecomment-449574535, the government of Nepal lists the province names as:

Province 1 Province 2 Province 3 Gandaki Province Province 5 Karnali Province Province 7

Update Province 4 to be Gandaki Province and Province 6 to be Karnali Province. This will require updating the geojson and topojson files as well as the geography SQL file.

See: https://www.nepal.gov.np/NationalPortal/EN

ravinepal commented 5 years ago

@divyamani1 - would you be interested in submitting a pull request on this issue?

divyamani1 commented 5 years ago

Sure. So,Province 4 and Province 6 should be changed to Gandaki Province and Karnali Province respectively, and I should update respective changes in the geojson, topojson and the geography SQL file?

ravinepal commented 5 years ago

yes!

On Sun, Feb 17, 2019 at 1:53 AM Divya mani Adhikari < notifications@github.com> wrote:

Sure. So,Province 4 and Province 6 should be changed to Gandaki Province and Karnali Province respectively, and I should update respective changes in the geojson, topojson and the geography SQL file?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Code4Nepal/nepalmap_federal/issues/52#issuecomment-464423077, or mute the thread https://github.com/notifications/unsubscribe-auth/ADlb6fy5NHS1UNOn3pW2Xg3MVw_s7Lu0ks5vOPxNgaJpZM4aLb45 .

--

cliftonmcintosh commented 5 years ago

Fulfilled by #57.

Thank you @divyamani1. Your work is now visible at https://beta.nepalmap.org

provinces-renamed