search

CodeforNepal / nepalmap_federal

Instance of NepalMap for federal Nepal. Join us!
https://nepalmap.org
MIT License
14 stars 20 forks source link

Upgrade pip on container start #72

Closed cliftonmcintosh closed 5 years ago

cliftonmcintosh commented 5 years ago

When starting the web container, there is a warning that pip is out of date and should be updated. This updates the container start to upgrade pip when it is being built.

amitness commented 5 years ago

@cliftonmcintosh Python 2 is being deprecated in the future, and upgrading pip gives the warning that pip will drop support for Python 2 automatically. Upgrading to the latest pip version might break our builds in the future. Let's not add this line until we have our codebase migrated to python 3.

PS: Right click image and open in new tab for clarity. image

cliftonmcintosh commented 5 years ago

@amitness

Yes, it's true that adding that line might result in pulling down a future version of pip that won't support python 2.7. That's a good point.

I do not know what wazimap's plan is for the end of life of python 2.7.