Closed ishandongol closed 4 years ago
Sure, Will do that.
On Sun, 1 Dec 2019, 02:19 Clifton McIntosh, notifications@github.com wrote:
@cliftonmcintosh commented on this pull request.
In wazimap_np/templates/homepage.html https://github.com/Code4Nepal/nepalmap_federal/pull/81#discussion_r352302832 :
@@ -24,14 +24,14 @@
Find facts
- On the beta version of NepalMap, population data is available. Soon more data will be added.
- On the beta version of NepalMap, demographics, agriculture, education and households data are available.
Consider using adjectives for all of the four categories: "demographic, agricultural, educational and household data" To me, "demographic, agricultural, education and household data" also sounds okay, but I think "educational" is probably better
In wazimap_np/templates/homepage.html https://github.com/Code4Nepal/nepalmap_federal/pull/81#discussion_r352303032 :
@@ -77,25 +77,27 @@
Exploring data
About {{ WAZIMAP.name }}
- NepalMap makes data on Nepal more accessible and understandable.
-
NepalMap is of great use to journalists, students, academics and others who are interested in using data to learn about Nepal.
-This tool is a friendly and reliable resource for journalists who want to use data to tell stories or discover stories that are of public interest.
-NepalMap uses data from Central Bureau of Statistics, and other official sources, to create user-friendly data visualizations on key demographic issues.
-You can embed, access or download the data too. You can also compare any two areas side-by-side.
-NepalMap is a project of Code for Nepal, a non-profit that works to increase digital literacy and the use of open data in Nepal. Please make a tax deductible donation to help us maintain the server space for NepalMap, and empower Nepal digitally!
-Code for Nepal's founder, Ravi Kumar, is grateful to all the volunteers who contributed to NepalMap! Code for Nepal is especially grateful to Clifton McIntosh, for serving as the lead developer for this project. And to Code for Nepal’s Amit Chaudhary.
-- NepalMap makes data on Nepal more accessible and understandable.
- NepalMap is of great use to journalists, students, academics and others who are interested in using data to learn about Nepal.
- This tool is a friendly and reliable resource for journalists who want to use data to tell stories or discover stories that are of public interest.
- NepalMap uses National Data Profile, created by Central Bureau of Statistics, and other official sources, to create user-friendly data visualizations on key demographic issues.
"the National Data Profile" instead of "National Data Profile"? "the Central Bureau of Statistics" instead of "Central Bureau of Statistics"?
Having "the" before each one seems more idiomatic to me, but maybe that's a regional difference.
In wazimap_np/templates/homepage.html https://github.com/Code4Nepal/nepalmap_federal/pull/81#discussion_r352303150 :
NepalMap branding is copyright of Code for Nepal and cannot be used without permission.
Help us
-
We are looking for volunteers who can help us add more data, and improve NepalMap. If you have the right skills, and would like to help, please complete this form! +
Code for Nepal is entirely built by volunteers who are committed to ensuring everyone has access to open data about Nepal. We need more help.
Would you consider adding a link to https://github.com/Code4Nepal/nepalmap_federal/graphs/contributors for "volunteers"?
Code for Nepal is entirely built by volunteers who are committed to ensuring everyone has access to open data about Nepal. We need more help.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Code4Nepal/nepalmap_federal/pull/81?email_source=notifications&email_token=AC3SLA2LRDURQV4MSAB4FFDQWLE5BA5CNFSM4JTHQMNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNO3CMY#pullrequestreview-324907315, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3SLAYASET3BAQWZEEF3LTQWLE5BANCNFSM4JTHQMNA .
Thank you, @ishandongol. With @cliftonmcintosh's suggestion incorporated, this looks good to go.
@cliftonmcintosh @ravinepal I have updated the content.
@ishandongol
After the merge of #80 , there is a conflict in the CSS file. Would you be able to resolve the conflict as part of this PR, please? It looks minor. I suspect it is the new line that was added in #80.
Sure, Will resolve the conflict.
On Sun, 1 Dec 2019, 22:01 Clifton McIntosh, notifications@github.com wrote:
@ishandongol https://github.com/ishandongol
After the merge of #80 https://github.com/Code4Nepal/nepalmap_federal/pull/80, there is a conflict in the CSS file. Would you be able to resolve the conflict as part of this PR, please?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Code4Nepal/nepalmap_federal/pull/81?email_source=notifications&email_token=AC3SLA27W5GQFQDZBZHR3VTQWPPNJA5CNFSM4JTHQMNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFRNT3A#issuecomment-560126444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3SLA67CMWTBP36ZTQJUQTQWPPNJANCNFSM4JTHQMNA .
@cliftonmcintosh i have resolved the conflict.
@ishandongol Lets incorporate @cliftonmcintosh suggestion and resolve these issues. It's okay if you do it while submitting the updated interface PR, when you are done with implementing Google Material Design and discussed changes.