CodeforNepal / nepalmap_federal

Instance of NepalMap for federal Nepal. Join us!
https://nepalmap.org
MIT License
14 stars 20 forks source link

Update local levels name at geography.sql #92

Closed nikeshbalami closed 4 years ago

nikeshbalami commented 4 years ago

While reviewing the population data, we found many spelling mistakes of local levels name in geography.sql file.

If possible update the SQL file will full name, for example, "Kathmandu" with "Kathmandu Metropolitan City" and so on, this will make the data adding part easier for upcoming days.

Will soon create and share a new sheet with existing geo_code; to discuss the possibilities.

nikeshbalami commented 4 years ago

Here goes the sheet with updated/changed name of local levels for SQL file: https://docs.google.com/spreadsheets/d/1Jcqcf2BDT6TqaUO-4HtOapZY0AkKI7Fgy2XR5K6hY-Y/edit?usp=sharing

pratimakandel commented 4 years ago

Great! I will test it and submit a pull request.

Sincerely, Pratima Kandel.

On Mon, Dec 16, 2019 at 11:42 PM Nikesh Balami notifications@github.com wrote:

Here goes the sheet with updated/changed name of local levels for SQL file: https://docs.google.com/spreadsheets/d/1Jcqcf2BDT6TqaUO-4HtOapZY0AkKI7Fgy2XR5K6hY-Y/edit?usp=sharing

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Code4Nepal/nepalmap_federal/issues/92?email_source=notifications&email_token=AJO6MHBFOR2C5JA5IXCSNDTQZBKFBA5CNFSM4J3E4S3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHBD4EQ#issuecomment-566378002, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJO6MHELY25L4J6SNS477HTQZBKFBANCNFSM4J3E4S3A .

nikeshbalami commented 4 years ago

@pratimakandel @cliftonmcintosh

Here goes the new sheet with the short name at "name" part and official name at "long_name" part. Let's update this at geography.sql table again: https://docs.google.com/spreadsheets/d/1EnnVMf6XzAxiw4qUBwKw683Ie9Z6y9hf5sn07VGgf38/edit?usp=sharing

nikeshbalami commented 4 years ago

Thank you @pratimakandel and @cliftonmcintosh

Solved by PR https://github.com/Code4Nepal/nepalmap_federal/pull/95, Closing this issue.