CodeforNepal / nepalmap_federal

Instance of NepalMap for federal Nepal. Join us!
https://nepalmap.org
MIT License
14 stars 20 forks source link

Design improvements #97

Closed ishandongol closed 4 years ago

ishandongol commented 4 years ago
cliftonmcintosh commented 4 years ago

One thing to note is that it would be good to make sure that our changes do not make it hard for us to bring in updates from the wazimap framework project.

If some of these changes could be useful for other organizations that use wazimap, we might consider making a pull request to wazimap itself in order to help with future compatibility.

cliftonmcintosh commented 4 years ago

@ishandongol

Thank you. Your changes have been deployed at https://beta.nepalmap.org

cliftonmcintosh commented 4 years ago

Here are screenshots from the old pre-federal site and the updated look on the beta site.

Before the updates on pre-federal site: comparing two districts pre-federal-comparison

After the updates on federal site: comparing two districts updated-comparison

ishandongol commented 4 years ago

Yes, was planning to increase the height of top bar.

On Thu, 26 Dec 2019, 21:32 Clifton McIntosh, notifications@github.com wrote:

@cliftonmcintosh commented on this pull request.

In wazimap_np/static/css/components/_pageheader.scss https://github.com/Code4Nepal/nepalmap_federal/pull/97#discussion_r361481502 :

  • // position: relative;
  • // height: $top-nav-height;
  • // #page-header-title{
  • // @include centerer;
  • // }

were these left in intentionally?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Code4Nepal/nepalmap_federal/pull/97?email_source=notifications&email_token=AC3SLA2CVNYCSSAPNTMABCDQ2TG23A5CNFSM4J673ZB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQHWIUA#pullrequestreview-336553040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3SLA2J7NL7SN6C45IWWBTQ2TG23ANCNFSM4J673ZBQ .

ishandongol commented 4 years ago

Do you mean the use of sass or design?

On Thu, 26 Dec 2019, 21:35 Clifton McIntosh, notifications@github.com wrote:

One thing to note is that it would be good to make sure that our changes do not make it hard for us to bring in updates from the wazimap framework project.

If some of these changes could be useful for other organizations that use wazimap, we might consider making a pull request to wazimap itself in order to help with future compatibility.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Code4Nepal/nepalmap_federal/pull/97?email_source=notifications&email_token=AC3SLA2LHUEPXI5BDY2QQYDQ2THCTA5CNFSM4J673ZB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHVXMQA#issuecomment-569079360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3SLA7OOH7I6RNNR3I2743Q2THCTANCNFSM4J673ZBQ .