search

CodeforSouth / fbi-api

😴 Florida Business Inspections API
http://138.197.90.94/
MIT License
13 stars 5 forks source link

#60 Function abstracions #64

Closed marcoslhc closed 7 years ago

marcoslhc commented 7 years ago

Promise next time I'll run the test first. Meanwhile can you check the concepts here @teh0xqb?

marcoslhc commented 7 years ago

Is there a way to link issues to PRs? just name them #60?

ccjoel commented 7 years ago

Is there a way to link issues to PRs?

@marcoslhc when you want the PR to automatically close the issue, set the last commit as "fixes #issue-number", or on the merge comment used to merge the branch (green buttton). If it has the "fixes#num" it will automatically close it. See https://help.github.com/articles/closing-issues-via-commit-messages

ccjoel commented 7 years ago

Not sure what you did that you ended up with +49 −56 ... only saved 7 lines! haha

marcoslhc commented 7 years ago

Who's counting LOC's XD There are some elements in the styling that adds for example the deconstructing of the arguments I use in some places are:

[{ key1: arg1
   key2: arg2
   ...
}]
ccjoel commented 7 years ago

Things are running correctly right now. I'm changing the vars renamed (from camelCase to dashes). but I see that the travis build failed. (inconsistently.. not sure).

ccjoel commented 7 years ago

Check the travis build and tests:

https://travis-ci.org/Code-for-Miami/restaurant-inspections-api/jobs/207230027

At least the last version I checked has a lot of errors in the tests. no idea what's going on.

ccjoel commented 7 years ago

nvm about me fixing the camel case stuff. lets fix these tests first..

marcoslhc commented 7 years ago

Should be good now. Recreate your copy of the branch (stash any changes first)