Codehagen / Dingify

Dingify is helping you unlock the power of seamless real-time monitoring
https://www.dingify.io/
GNU Affero General Public License v3.0
191 stars 25 forks source link

fix: charts tooltip theme color for darkmode #15

Closed Amirthananth closed 4 months ago

Amirthananth commented 4 months ago

Description

The chart tooltip text visibility is affected in dark mode. Introduced a different bg and fg color for the charts to make the text suit for both themes (light and dark).

What type of PR is this? (check all applicable)

Related Tickets & Documents

This PR fixes #12

Mobile & Desktop Screenshots/Recordings

Light Mode

image_light

Dark Mode

image_dark

Steps to QA

  1. Change theme to light/dark mode
  2. Hover on top of the graph and try to read the data

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

vercel[bot] commented 4 months ago

@Amirthananth is attempting to deploy a commit to the meglerhagen's projects Team on Vercel.

A member of the Team first needs to authorize it.

Amirthananth commented 4 months ago

@Codehagen Do review and let me know. I've also added a few styles to the funnel chart to keep it consistent with the other chart.