search

Codeinwp / Ideal-Image-Slider-JS

Quite simply the ideal Image Slider in vanilla JS.
http://idealimageslider.com
GNU General Public License v3.0
1.57k stars 160 forks source link

Scroll Prevention for touch devices #14

Closed wesbos closed 10 years ago

wesbos commented 10 years ago

Most users to not swipe on a perfectly straight X axis, which makes the swiping on this app inconsistent.

Most of the time the slider just skips to the next slide rather than transitioning.

Check this video for an example: http://wes.io/XNBa - every single time I intend to swipe, but the page scrolls up and down and skips the slide to the next.

Swipe.js has a fantastic implementation of this: http://swipejs.com/ - the project is dead but I still use this slider in every project because of the scroll prevention and the "scroll as you touch" effect as pointed out in #13

gilbitron commented 10 years ago

Yeh this is definitely something I want to sort. I'll maybe have a look at swipejs. The only issue I have is that I don't want the slider to have any dependencies, so whatever we do it will have to be baked in.

wesbos commented 10 years ago

Oh yes, sorry, SwipeJS is another slider so you wouldn't have a dependency, just look at how they do it.

Swipejs was great because it was pure js with no depends, really simple and it worked really well. I hope that this lib is the next slider. It looks great!

gilbitron commented 10 years ago

Ok cool. I'll take a look.

gilbitron commented 10 years ago

I've implemented this in v1.1.0