Codeinwp / Ideal-Image-Slider-JS

Quite simply the ideal Image Slider in vanilla JS.
http://idealimageslider.com
GNU General Public License v3.0
1.57k stars 160 forks source link

images with spaces won't load #61

Open ebbmo opened 9 years ago

ebbmo commented 9 years ago

Hi Gilbitron,

I noticed an issue when implementing the slider - if an image in a folder contains a space, the image will not load. Removing the space in the file name solves the error. This affects images inserted with the "data-src=" property - for "src=" it works (standard html).

Do you think you could fix that?

Thanks & kind regards, ebbmo

RomainSauvaire commented 9 years ago

Hi @gilbitron common advice here is to avoid spaces in folders/filenames. Anyway I tested with spaces in filenames and it worked like a charm. Can you display the images without initializing them thought the slider ? BTW, what browser are you using... could be helpful for debug

ebbmo commented 9 years ago

Hi Romain,

I agree with your advice on avoiding spaces. My issue is that the slider will display dynamically read pictures from a folder. And these pictures will be updated regularly. So even though I will tell the user to avoid spaces it might as well happen :/

I inserted the picuters without the slider - both display just fine (with & without space). I am using Chrome (Version 40.0.2214.115 (64-bit)

My setup is as follows:

In case you need my coding, let me know.

Kind regards, ebbmo