search

Codeinwp / bookrev-lite

🚩 [RETIRED]
0 stars 9 forks source link

!!! Updated theme to current standards #47

Closed HardeepAsrani closed 8 years ago

HardeepAsrani commented 8 years ago

Close https://github.com/Codeinwp/bookrev-lite/issues/46

Many commits so please check commits for more info. @rodica-andronache

ineagu commented 8 years ago

@rodica-andronache since we did this, can we create a much better screenshot ? the current one is awful

HardeepAsrani commented 8 years ago

I will send one. :)

rodica-andronache commented 8 years ago

@HardeepAsrani thanks :) Will just have to change back the strings changed here https://github.com/Codeinwp/bookrev-lite/pull/47/commits/499f951a137ab990d7ef08253231167f4ce33186 to not change the translations percentage on wp.org as I mentioned on Bookrev. Andrei will take care of the screenshot.

HardeepAsrani commented 8 years ago

@rodica-andronache I didn't change any strings, so can you screenshot it so I could see? Must be a mistake from my side.

Also just noticed this:

wp_enqueue_style( '<font-></font->awesome', get_template_directory_uri() . '/css/font-awesome.min.css');

My IDE turned font in font awesome to ` tag.

So let me know the string mistake so I could fix both. :)

rodica-andronache commented 8 years ago

I mean this http://pasteboard.co/ho9C3EggQ.png , when you changed ... to &hellip; :D but I already reversed it here https://github.com/Codeinwp/bookrev-lite/commit/f072f5fb93d622114c6817e1ce04c552f2b6cac6

You can still fix the fontawesome issue, I didn't notice it

HardeepAsrani commented 8 years ago

Oh, got it. Thanks.