Add modify links action

Codeinwp / feedzy-rss-feeds

FEEDZY RSS Feeds is an easy-to-use plugin giving you RSS aggregator and autoblogging functionality. Bring the best RSS feeds to your site.

GNU General Public License v2.0

79 stars 26 forks source link

Closed girishpanchal30 closed 3 weeks ago

girishpanchal30 commented 2 months ago

In this PR, I've added modify links action to modify the <a></a> HTML attributes.

[ ] I have written a test and included it in this PR
[x] I have run all tests and they pass
[x] The code passes when running the PHP CodeSniffer
[x] Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
[x] Security and Sanitization requirements have been followed
[x] I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

pirate-bot commented 2 months ago

Plugin build for 08a424c768d3e7a79db145888215a4bcda7c00df is ready :bellhop_bell:!

AndreeaCristinaRadacina commented 2 months ago

@girishpanchal30, thank you for taking care!

Here are my findings:

there are some weird characters appearing for certain parts of the content (those were not links before)
the panel doesn't have the same structure as in your screenshot:
I set the links to open in the same tab and be nofollow, but this is not respected on the frontend:

girishpanchal30 commented 2 months ago

@AndreeaCristinaRadacina

there are some weird characters appearing for certain parts of the content (those were not links before)

Can you please share Feed URL?

the panel doesn't have the same structure as in your screenshot:

It could be a cache issue on your end; everything looks fine from my side. Ref: https://tinyurl.com/25lj2l7p

AndreeaCristinaRadacina commented 2 months ago

@girishpanchal30 here is the feed: https://wpshout.com/feed

girishpanchal30 commented 2 months ago

@AndreeaCristinaRadacina I've fixed the mentioned issue with the latest commit.

AndreeaCristinaRadacina commented 2 months ago

@girishpanchal30 I am not sure why, but when using the Modify links action, the import no longer works:

Instance:

Also, from the previous comment (just making sure), have you checked this too?

I set the links to open in the same tab and be nofollow, but this is not respected on the frontend:

girishpanchal30 commented 2 months ago

@AndreeaCristinaRadacina It seems issue with PHP 8, now it fixed with the latest commit.

AndreeaCristinaRadacina commented 2 months ago

@girishpanchal30, great! It works as expected now. Thank you!

pirate-bot commented 3 weeks ago

:tada: This PR is included in version 4.4.14 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: