search

Codeinwp / hestia

Updated Changelog: https://bit.ly/2T73vWG
9 stars 8 forks source link

Contact section headings inconsistency #48

Closed MarinescuLucia closed 1 year ago

MarinescuLucia commented 2 years ago

The title of the Contact Us section is h2 and the description below it is h5, which may not be ideal for assistive technologies such as screen readers. A user suggested that changing the description from h5 to h3 would be an improvement in terms of accessibility.

tempsnip

Reported here.

girishpanchal30 commented 2 years ago

Hello @MarinescuLucia,

I reviewed the front page sections and found a similar structure in the below sections. Should I change user suggested structure for all sections?

1) What clients say 2) Meet our team 3) Products 4) Why our product is the best

cc @cristian-ungureanu

Thanks

MarinescuLucia commented 2 years ago

Hi @girishpanchal30,

Sorry for the delay, I had the week off. Indeed it looks like this structure is repeated in multiple sections on the frontpage, including the Blog and Subscribe sections, besides those that you already mentioned. For accessibility reasons, I think we could consider changing this structure for all of them.

Thoughts @cristian-ungureanu?

cristian-ungureanu commented 2 years ago

@MarinescuLucia @girishpanchal30 this was the initial design as you can see here https://demos.creative-tim.com/material-kit-bs4/examples/landing-page.html. I think we can stick to it, not changing anything for now. The changes will produce lots of other visual issues.

@abaicus @selul ehat do you think?

abaicus commented 2 years ago

@MarinescuLucia Did a customer complain regarding this in a more elaborated manner? It's not optimal from an a11y perspective indeed, but it shouldn't affect screen readers flow unless headings are all over the place.

MarinescuLucia commented 2 years ago

@abaicus No, the user didn't provide other details. He just gave a heads up about this (mentioned only the contact section) not being ideal for accessibility here.