search

Codeinwp / neve-fse

The theme you already love, built for Full-Site Editing
15 stars 6 forks source link

Add WP.org review notice as we have for Neve and other products #63

Closed mghenciu closed 1 year ago

mghenciu commented 1 year ago

What problem does this address?

In order to increase the number of Reviews. I think this is already implemented in Themeisle SDK and we can easily add it, in all FSE themes.

What is your proposed solution?

What is different in this case is that we already have some notices inside, so this one should appear only after those are already dismissed/expired.

For Neve FSE we have the survey notice, while for other FSE themes - we have the notice promoting Otter blocks.

As discussed on Slack, I suggest:

Will this feature require documentation? (Optional)

None

HardeepAsrani commented 1 year ago

@mghenciu Which notice in particular are you talking about?

mghenciu commented 1 year ago

@mghenciu Which notice in particular are you talking about?

I don't have a Screenshot for that. But I am pretty sure you know the notice. It's the one that says something about giving us a rating, and is signed by one of us; and it appears in the attached area: Screenshot 2023-08-01 at 10 20 08

So it's something like: Hey, please help us with a review on WPorg. Lorem ipsum wayfarers poke, gentrify kombucha af. Hot chicken asymmetrical squid, selvage pop-up selfies direct trade fingerstache mumblecore pug deep v. Hardeep - Neve FSE Developer

selul commented 1 year ago

@HardeepAsrani it's about the review notice from the SDK, which I think is already available since we are using the SDK on Neve FSE

HardeepAsrani commented 1 year ago

Yes, that's why I was confused. That isn't added by us manually to each product. It's available from the SDK.

It's only available after a the product has been installed for a certain amount of time, that's 100 hours.

If you want to test, you can go to wp-admin/options.php in your WP, find the option neve_fse_install or whatever the name is, and change that time string to something a week in past and it should appear.

Screenshot 2023-08-01 at 1 11 31 PM
mghenciu commented 1 year ago

Ok, thank you for the explanation and I apreciate all the details @HardeepAsrani. Then I guess we can close this one, since the Review Notices are already included in the SDK, for our FSE themes.

I'll also post an update in the discussion Slack.