single customization options as gutenberg plugin sidebar

[selul]

Description:

Right now we have the single page options as old editor meta box inside the admin. We need to look into moving this setting to Gutenberg plugin sidebar

Some things that we need to take care of:

• [x] Radios that we have now for sidebar and content should be using the same format as the customizer ( using image icons )
• [x] For classic editor, we should keep the same meta box as now, only people using the new editor should see this.
• [x] Block Editor width should react to the changes of the content and sidebar options. Right now it requires a refresh for the width to be updated.

[selul]

adding here the new design that John made

Some things regarding the implementation:

• [x] For users with Classic Editor: We keep the current meta box and it's settings only, we don't add the new ones from design. Basically the current code will become legacy and will be showing only on users without Gutenberg
• [x] For users with the new editor: We keep the meta box but we show a legacy message instead, i.e 'The individual content settings were moved.' with a picture/gif which should show the focus on the neve icon.
• [x] For settings that are common with the legacy meta box, they changes should be consistent, i.e the content width in legacy or new sidebar should use the same values.

[selul]

Adding some things here based on the progress we have right now, just to make sure we don't miss them. If those are present, we can ignore them.:

• [x] we need to make sure that content width slider shows only if the toggle is on
• [x] Pro elements should not be present in the sidebar elements toggle options.
• [x] We need to make sure we have the sidebar notice that is present in the design is added in the sidebar Metabox.
• [x] Bonus point, would be great if we can open the sidebar with a keyboard shortcut ( CMD/CTRL + N +V ) and show the shortcut info in the legacy notice.

[rodica-andronache]

@cristian-ungureanu here is what I saw while testing

• [x] Here the label should be Sidebar instead of Container

• [x] I think it would be a good idea to keep the % here, as it was before, likeCustom Content Width(%)
  

• [x] For Comments and Tags, I’m not sure I understand if checking that option will enable or disable comments/tags (maybe we should also update the label for those options). For example for comments, at first, the comments are visible on the frontend, and in the editor the option is not checked. If I go and check it, nothing changes in the frontend. If I go and uncheck it, the comments disappear from frontend. There's probably an issue with the default value. But the label is also misleading, being close to the other elements that are called "Disable X" Same thing happens for Tags.

https://www.loom.com/share/ad1ef4afec3643c1bee10d7c044bb042

• [x] It’s ok to have Author Avatar andReading time options available even when Page Meta is disabled, and they don't control anything?

• [x] The Neve Options appear in Custom Layouts as well. And if you click on the Neve icon this is what you get. Same thing happens for other CPTs registered with other plugins

• [x] the message still appears even when the option is set to inherit for the shop sidebar

The message could also be updated to “Note: It seems that the shop page has an individual sidebar layout already set. To be able to control the layout from here, edit your page and set the sidebar to “Inherit”

• [x] We already have % Options translated and now added % options (lowercase). We can have it the same to don’t add a new string.

[cristian-ungureanu]

@rodica-andronache All the issues you've mentioned are now fixed. Let me know if there is anything else.

[rodica-andronache]

@cristian-ungureanu

• [x] with Neve PRO activated, enable all Elements for a post and save it.

after that, deactivate Neve PRO. -> The Author Biography, Related Posts and Sharing Icons still remain in the list, in this form

• [x] another thing, I would rename "Page Title" to "Post Title" and "Page Meta" to "Post Meta" to match the other ones

[cristian-ungureanu]

@rodica-andronache fixed this as well

[rodica-andronache]

couldn't find other issues 👍 I just had a suggestion if you think it makes sense. To not display all the options from the Neve sidebar, when a post or page has the Elementor Full Width or Canvas templates, as they don't actually do anything. I find this confusing after I import a starter site, which has these types of templates, and I go over to edit the pages/posts.

[rodica-andronache]

@cristian-ungureanu I'm still testing this. So far, saw these two issues

• [x] https://www.loom.com/share/ab10222000704f40860e9a5161b71157

  1. Change the title alignment to the right side.
  2. Do any change to the Elements order ( hide one of the elements )
  3. Save the changes -> The title alignment goes back to left aligned and it can't be changed anymore

• [x] https://www.loom.com/share/9bf4a74edd5d4df3b1eb9ff3597e0e3d

  1. Create a new post
  2. Change the order of the Elements -> an error appears in the console and the new order can't be changed

[rodica-andronache]

For this one, I'm not sure if it's correct or not https://www.loom.com/share/32b467bb30ea466cb78ab33cf7b214bf By default, when creating a page, the Container is set to Default and Custom Content Width is 100%. But the way the content looks in the editor is different than what it looks like on the frontend. Only if you set Container to Full Width, the editor and frontend looks the same

[cristian-ungureanu]

For this one, I'm not sure if it's correct or not

https://www.loom.com/share/32b467bb30ea466cb78ab33cf7b214bf By default, when creating a page, the Container is set to Default and Custom Content Width is 100%. But the way the content looks in the editor is different than what it looks like on the frontend. Only if you set Container to Full Width, the editor and frontend looks the same

About this, it's the same logic that we apply on the frontend. The issue is that the editor is not wide enough when contained and set to 100%. Here's a video that explains it https://www.loom.com/share/25238939c8404b9f8fbfa3dcf45caf98

[rodica-andronache]

@cristian-ungureanu for Pages, by default the Sidebar is set to None. After resetting the options, the Sidebar is set to Inherit ( which has a sidebar by default ) https://www.loom.com/share/0dc7f1565b654eb78ce86e756b32304c

[rodica-andronache]

@cristian-ungureanu the default order for Elements in Posts is not the same as on frontend. In the editor, the order is : Post Title, Featured Image, Tags, Post meta, Content, Comments

while on frontend, the order is Post Title, Post meta, Featured Image, Content, Tags, Comments

[cristian-ungureanu]

@cristian-ungureanu for Pages, by default the Sidebar is set to None. After resetting the options, the Sidebar is set to Inherit ( which has a sidebar by default )

https://www.loom.com/share/0dc7f1565b654eb78ce86e756b32304c

@rodica-andronache for new pages we set the meta to sidebar none and content width 100% when the page is published. Those are not the defaults, the defaults are the settings from the customizer. The reset button should "erase" the meta. It shouldn't get back to "none", it should go back to customizer settings which are applying if there is no meta.

[pirate-bot]

:tada: This issue has been resolved in version 2.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: