search

Codeinwp / neve

A fast, lightweight, AMP ready WordPress theme built with speed and usability in mind.
https://themeisle.com/themes/neve/
GNU General Public License v2.0
263 stars 84 forks source link

[Neve 3.3 test] Starter sites issues #3523

Closed irinelenache closed 2 years ago

irinelenache commented 2 years ago

Description:

Here i'll post a list of inconsistencies between demosites.io and the actual import of FREE starter sites

Fitness gutenberg:

Photography gutenberg:

Architecture gutenberg:

Yoga studio:

ref: https://github.com/Codeinwp/neve-pro-addon/issues/1532

The starter sites i reviewed for now: Gutenberg - Web agency, Blogger, Neve 3, Fitness, Photography, Architecture studio, Lawyers, Yoga studio

Will come back with comments when i review more of them šŸ§

irinelenache commented 2 years ago

Wedding guttenberg:

Pet shop:

Restaurant:

Music band:

Drone:

Fitness trainer:

Vacation rental:

āœ… For now, all free starter sites made with gutenberg are reviewed

JohnPixle commented 2 years ago

Thanks for reporting all these @irinelenache. By scanning the bullets for each site in your comment I see many of them have a "technical" twist :) I believe that the fix for those would be to just re-define the values on the controls. Regarding the image sizing, I have no idea, but there might be a fix by the same way.

@mghenciu let me know how you see fit to approach this, and if you need any help of course.

irinelenache commented 2 years ago

@JohnPixle @mghenciu Also tested the import of 10 starter sites (with Elementor as builder) and didn't encounter any problem for now, like misaligned things or missing ones. Will update here when i test more.

I wanted to mention that on the import, you get Elementor 3.6.7, so if we don't find any problems regarding how the imports look, can we update Elementor on demosites too?

irinelenache commented 2 years ago

Tested most of the Elementor starter sites now and found a single problem:

Restaurant(gb):

Images are not getting imported on Reservations page https://vertis.d.pr/tuvHNq

^ Same happens for the Elementor one

JohnPixle commented 2 years ago

@irinelenache

I wanted to mention that on the import, you get Elementor 3.6.7, so if we don't find any problems regarding how the imports look, can we update Elementor on demosites too?

Yes, this would be great actually, we need a newer version of Elementor in demosites šŸ‘šŸ»

irinelenache commented 2 years ago

Pro starter sites issues(gutenberg):

Craft beer:

Business:

Medicare:

Speed:

Accounting:

Audio books:

Architecture studio:

Personal blog:

Fishing and hunting:

Conference:

University:

Resume 2:

Museum:

Product launch:

Industrial:

āœ… All gutenberg starter sites are reviewed now

cristian-ungureanu commented 2 years ago

Hey @preda-bogdan, seems like there are some issues regarding the imports. Can you please have a look at this? If there are some actions related to the setup of the starter sites I think @mghenciu can help.

mghenciu commented 2 years ago

@preda-bogdan , as promised, here are a few technical things we can look into:

image Screenshot 2022-07-20 at 21 08 23

The other issues mentioned by Irinel, are builder related and I will fix them.

preda-bogdan commented 2 years ago

Thank you @mghenciu I will start looking into those.

preda-bogdan commented 2 years ago

@mghenciu I've fixed the mentioned issues inside the templates-patterns-collection plugin. You can test using the linked PRs for each issue reported.

Let me know if this solves the issues for you, also if you encounter other tech issues with regards to import I'll take care of them just tag me.

preda-bogdan commented 2 years ago

@irinelenache when you have some time can you confirm that the PRs linked are solving the issues mentioned by @mghenciu for the technical side?

Thank you!

cristian-ungureanu commented 2 years ago

Hey @preda-bogdan, feel free to close this issue if all the problems are resolved.

mghenciu commented 2 years ago

Hey @preda-bogdan, feel free to close this issue if all the problems are resolved.

I'll focus on this issues today and get back with an update.

mghenciu commented 2 years ago

All the issues are fixed now, on the mentioned Starter Sites.

With the exception of the Woo related issues where the image is different on import. I am not sure we can export/import that. It's not a big issue, just after import the images are squares. And on the Architecture demo, on import the widgets worked for me.

I think we can close this one, and retest in the next month.