cristian-ungureanu
commented
10 months ago I am not sure how to solve this one. Here's what happened:
- In this issue https://github.com/Codeinwp/neve/issues/2978 there was a concern that "Default H2 is still big when you have long H2 in content" so we switched to H3 in Neve 3.0.
- After this, users were not happy with the change, and we switched back to H2 without changing the control options here: https://github.com/Codeinwp/neve/blob/master/assets/scss/components/elements/blog/_typography.scss#L10
Now comes the tricky part. If we fix this to work as it should, the font size of the headings will suddenly change on the user's sites if they didn't actually set the typography for the blog.
In summary, the "blog-entry-title" class is controlled from 2 places:
- From its own settings
- From the general Headings control ( but H3 instead of H2 ) if its own settings aren't set
If we fix the issue, some people that don't have typography for blogs in place will experience some unwanted changes. If we don't fix the issue, the title can still be changed.
An idea is to apply the fix for new users only but we might overcomplicate things.
Let me know what you think.
HardeepAsrani
Description
Coming from this ticket, I've noticed that on the blog page we have H2 headings for the titles, but H3 typography options(except font size) apply there, which is confusing. Not sure if it's a bug or not. Saw this as well https://github.com/Codeinwp/neve/issues/3107
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet or Help Scout ticket
Environment info
No response
Is the issue you are reporting a regression
No