Codeinwp / neve

A fast, lightweight, AMP ready WordPress theme built with speed and usability in mind.
https://themeisle.com/themes/neve/
GNU General Public License v2.0
264 stars 84 forks source link

Multisite issues #4117

Open cristian-ungureanu opened 11 months ago

cristian-ungureanu commented 11 months ago

Description

There are still some issues regarding a multisite instance and permissions. We should discuss them and decide what should happen in each specific case. Here are the known issues so far:

( More things can be added here after testing more cases here )

Step-by-step reproduction instructions

On a multisite, as an administrator with no rights regarding the plugins, with Neve and TPC activated, click on the welcome notice button

Screenshots, screen recording, code snippet or Help Scout ticket

https://vertis.d.pr/v/PDqBwZ

Environment info

No response

Is the issue you are reporting a regression

No

rodica-andronache commented 11 months ago

https://github.com/Codeinwp/templates-patterns-collection/issues/292

girishpanchal30 commented 1 month ago

@vytisbulkevicius I attempted to replicate this with a multisite setup, but it seems to be working fine now.

@rodica-andronache Could you please check if this issue still exists and try to reproduce it on your end?

Thanks

rodica-andronache commented 3 weeks ago

@girishpanchal30 yes, I'm still able to replicate this, following the same steps mentioned in the issue and in the video

girishpanchal30 commented 3 weeks ago

@rodica-andronache

The user is unable to access the plugin menu page due to permission restrictions. To resolve this, we should enable the plugin menu setting, which will allow access to the tiob-starter-sites page.

Ref: https://tinyurl.com/2xn74shl

Could you please verify with the mentioned setting option?

Thanks

poonam279 commented 2 weeks ago

@girishpanchal30 we have tried but couldn't replicate the reported issue. Whenever I click on Try one of our ready to use starter site button, the onboarding appears. @rodica-andronache will confirm when she will be back on Monday.

rodica-andronache commented 1 week ago

@girishpanchal30 yes, that's the reason. But the issue is mentioning this "as an administrator with no rights regarding the plugins".

From what I understand, the solution for the issue would be to probably not show the "Try one of our ready to use starter site" button or the entire notice for this case, for administrators without rights to install plugins, so we don't have this case.

Let me know if there is something else I can help with here

girishpanchal30 commented 6 days ago

@rodica-andronache I've hidden the notice as per your suggestion, please check with this PR https://github.com/Codeinwp/neve/pull/4299

rodica-andronache commented 5 days ago

@girishpanchal30 it's working well