Codeinwp / neve

A fast, lightweight, AMP ready WordPress theme built with speed and usability in mind.
https://themeisle.com/themes/neve/
GNU General Public License v2.0
263 stars 84 forks source link

Add a second Nav_Walker for Secondary Menu #4235

Closed Soare-Robert-Daniel closed 6 months ago

Soare-Robert-Daniel commented 7 months ago

Summary

The Secondary Menu was using only the default WordPress Nav Walker. Because of this, some missing elements prevented the Mobile Sidebar from working.

Since only the primary menu could enqueue those resources, the secondary menu did not work correctly in his absence.

To fix this, I added a new class that inherits all the functionality of the Nav_Walker but enqueues only the needed resources.

Will affect visual aspect of the product

NO

Screenshots

Test instructions

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2802

pirate-bot commented 7 months ago

Plugin build for 423260514e4fe010646e9b0a7e9360c368a915db is ready :bellhop_bell:!

irinelenache commented 6 months ago

@Soare-Robert-Daniel Tested and the issue is fixed now ✅

pirate-bot commented 4 months ago

:tada: This PR is included in version 3.8.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: