Codeinwp / neve

A fast, lightweight, AMP ready WordPress theme built with speed and usability in mind.
https://themeisle.com/themes/neve/
GNU General Public License v2.0
263 stars 84 forks source link

Added new starter site content #4258

Closed girishpanchal30 closed 4 months ago

girishpanchal30 commented 5 months ago

Summary

I've changed the starter site content according to the new starter site(Marketing Agency). Issue - https://github.com/Codeinwp/neve-pro-addon/issues/2823

Check before Pull Request is ready:

Closes Codeinwp/neve-pro-addon#2823

pirate-bot commented 5 months ago

Plugin build for 319a6a076aeb943de631ab1431ac44de3a10f973 is ready :bellhop_bell:!

girishpanchal30 commented 5 months ago

@harshitarora-in I've updated icons from the zip, please recheck with build zip, thank you

harshitarora-in commented 5 months ago

@harshitarora-in I've updated icons from the zip, please recheck with build zip, thank you

@girishpanchal30 After installing the build, I cannot see the new icons in the onboarding or even in the editor; it is still using the old ones. Please let me know if I am missing anything.

https://vertis.d.pr/i/7REj6B https://vertis.d.pr/i/ZauLhp https://vertis.d.pr/i/DhkZD5

Test Instance

Site name: Reflective Flock URL: https://reflectiveflock.s2-tastewp.com Username: harshit8121 Password: dZDob2cbZr8

girishpanchal30 commented 5 months ago

@harshitarora-in I've changed is reflected in starter content not in the starter site library. Ref: https://tinyurl.com/3xdt467s

The starter site library is managed by the Templates Patterns Collection plugin.

harshitarora-in commented 5 months ago

The starter site library is managed by the Templates Patterns Collection plugin.

@girishpanchal30 Then please make the changes in the Templates Patterns Collection repository as well because we need consistent icons everywhere.

Also, as we are currently updating the Templates Patterns Collection repo, please move the Marketing Agency starter site to the beginning.

selul commented 5 months ago

@harshitarora-in this needs to be done on the demo API endpoint, @preda-bogdan can help with this, please suggest a position for it.

rodica-andronache commented 5 months ago

@girishpanchal30 there are differences on mobile, compared to https://demosites.io/marketing-agency/?noCache=true Screenshot on 2024-06-30 at 16-15-02 Screenshot on 2024-06-30 at 16-14-48

Screenshot on 2024-06-30 at 16-15-35 Screenshot on 2024-06-30 at 16-15-19

girishpanchal30 commented 4 months ago

Hey @rodica-andronache,

The demo site is created on the Elementor plugin and Elementor has its controls to manage the responsive. and our starter site content is created using Gutenberg, so I think we can't make it responsive as per the demo site without using any blocks plugin like Otter Blocks plugin.

@selul @harshitarora-in If you have any suggestions or solutions please share them here, so we can fix the responsive issue as well.

Thank You

selul commented 4 months ago

@girishpanchal30 here is the gutenberg version of it https://demosites.io/marketing-agency-gb/, is the responsiveness similar ?

girishpanchal30 commented 4 months ago

@selul Yes, I've added starter site content from this https://demosites.io/marketing-agency-gb/ demo site and it looks like same.

harshitarora-in commented 4 months ago

@girishpanchal30 @selul While creating the starter site, Mihai mentioned that this is the maximum responsiveness we can achieve with the core blocks, as we are using a complex background for the hero section (which is not completely responsive for mobile devices).

cc: @rodica-andronache

pirate-bot commented 4 months ago

:tada: This PR is included in version 3.8.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: