Codeinwp / neve

A fast, lightweight, AMP ready WordPress theme built with speed and usability in mind.
https://themeisle.com/themes/neve/
GNU General Public License v2.0
263 stars 84 forks source link

Fixed lightbox issue with alignment control #4297

Closed girishpanchal30 closed 3 weeks ago

girishpanchal30 commented 2 months ago

Summary

Fixed issue with WP default lightbox model.

Test instructions

  1. Add an image block
  2. enable “Expand on click” for the image
  3. change the alignment of the image ( left/right/center) -> when an alignment option (other than None ) is enabled, the image doesn't expand to full width

Check before Pull Request is ready:

Closes #4260

pirate-bot commented 2 months ago

Plugin build for 9afa3f42d5d982959adb423bd0ed962a261f24eb is ready :bellhop_bell:!

rodica-andronache commented 2 months ago

tested and it's working well 👍

selul commented 2 months ago

@girishpanchal30 we are not looking to increase the CSS limit so please review the solution within the boundaries.

girishpanchal30 commented 2 months ago

@selul I've added an inline style instead of adding CSS in the main style.

rodica-andronache commented 2 months ago

tested and it's still working

pirate-bot commented 3 weeks ago

:tada: This PR is included in version 3.8.12 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: