search

Codeinwp / neve

A fast, lightweight, AMP ready WordPress theme built with speed and usability in mind.
https://themeisle.com/themes/neve/
GNU General Public License v2.0
263 stars 84 forks source link

Possible issue with TranslatePress in latest versions of Neve #4301

Closed rodica-andronache closed 3 weeks ago

rodica-andronache commented 2 months ago

Description

I was not able to replicate this.

This user wanted to upgrade from Neve 3.5.8 to the latest version, while using TranslatePress. When switching to the newest version, none of the translations work anymore.

He pinpointed the issue with this symbol "←" which we use for the title in here https://github.com/Codeinwp/neve/blob/master/header-footer-grid/templates/components/component-logo.php#L49

He is wondering why we use that and if we can remove it.

Step-by-step reproduction instructions

I was not able to replicate this.

Screenshots, screen recording, code snippet or Help Scout ticket

https://secure.helpscout.net/conversation/2641939607/424322?viewId=212385

Environment info

No response

Is the issue you are reporting a regression

No

girishpanchal30 commented 2 months ago

@rodica-andronache I've reviewed the issue and was unable to replicate it.

He is wondering why we use that and if we can remove it.

To address this, I replaced the hardcoded icon with Unicode arrows.

Could you please ask the customer to test the changes using the PR build zip?

Thanks

rodica-andronache commented 2 months ago

I've asked the user, but didn't get a reply so far. I'm waiting for that

rodica-andronache commented 1 month ago

there was no answer from the user here