Fixed load textdomain issue with WP 6.7

Codeinwp / neve

A fast, lightweight, AMP ready WordPress theme built with speed and usability in mind.

https://themeisle.com/themes/neve/

GNU General Public License v2.0

263 stars 84 forks source link

Fixed load textdomain issue with WP 6.7 #4325

Closed girishpanchal30 closed 2 days ago

girishpanchal30 commented 4 days ago

Summary

I have removed the early translation function call following WordPress standards.

Check before Pull Request is ready:

[ ] I have written a test and included it in this PR
[x] I have run all tests and they pass
[x] The code passes when running the PHP CodeSniffer
[x] Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
[x] Security and Sanitization requirements have been followed
[x] I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes https://github.com/Codeinwp/neve/issues/4322

pirate-bot commented 4 days ago

Plugin build for 3d5670c7a126fa187e18041843a49aee221b3ff7 is ready :bellhop_bell:!

Download build

rodica-andronache commented 3 days ago

tested and it's working well

selul commented 3 days ago

@rodica-andronache @vytisbulkevicius is the whitelabel still working after this? Whitelabel for theme details.

vytisbulkevicius commented 3 days ago

It still works:

But we need to apply same fix for https://github.com/Codeinwp/neve-pro-addon/ and check again then as there is still a warning coming from plugin code. @girishpanchal30, please apply the fix for neve-pro-addon as well

girishpanchal30 commented 3 days ago

@vytisbulkevicius Can you please share your test instance details?

vytisbulkevicius commented 3 days ago

@girishpanchal30,

Sure:

Admin area URL: https://partcent.s1-tastewp.com/wp-admin Username: bvytis Password: tIFXkDiUUHw

girishpanchal30 commented 3 days ago

@selul @vytisbulkevicius I've reviewed the neve-pro-addon code and noticed that this function is being loaded too early, along with some translatable strings.

I attempted to move the code to the init hook, but doing so appears to break the WP_CLI commands for Neve theme.

I've been working on finding a solution for this issue. If you have any ideas or suggestions, please let me know.

Thanks!

girishpanchal30 commented 2 days ago

@selul @vytisbulkevicius I’ve loaded the CLI module separately with this PR, and it seems to be working fine.

Could you please test the WP-CLI commands registered by Neve and let me know if you encounter any issues?

Thanks!

girishpanchal30 commented 2 days ago

@selul @vytisbulkevicius Please ignore the neve-pro-addon PR. I’ve resolved the issue within the neve theme PR itself, and everything now appears to be working fine with neve-pro-addon.

vytisbulkevicius commented 2 days ago

Tested and don't see warnings anymore. The Whitelabel still works so looks good.

pirate-bot commented 2 days ago

:tada: This PR is included in version 3.8.14 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: