search

Codeinwp / nivo-slider-lite

The official WordPress plugin for the Nivo Slider (Lite)
GNU General Public License v3.0
4 stars 9 forks source link

notice issue #21

Closed ineagu closed 5 years ago

ineagu commented 5 years ago

When I click on try notice I get this https://www.dropbox.com/s/hofkwg19ni160pv/Screenshot%202018-11-20%2016.28.04.png?dl=0, I think is better to redirect it at least to something like this : https://www.dropbox.com/s/mkzalnj411ei0lg/Screenshot%202018-11-20%2016.29.30.png?dl=0

ineagu commented 5 years ago

cc @selul

selul commented 5 years ago

@ineagu this is due to poopy site, it adds a padding top too which breaks that iframe. is not happening to users, if you test on wpsandbox or any other site it will show fine.

ineagu commented 5 years ago

Not the white space was the main problem, from the opened iframe users can’t install the plugin easily it seems to me

On Nov 21, 2018, at 3:10 PM, Marius Cristea notifications@github.com wrote:

Closed #21.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.