fix: resize leaflet maps on resize

Codeinwp / otter-blocks

Create beautiful and attracting posts, pages, and landing pages with Gutenberg Blocks and Template Library by Otter.

https://wordpress.org/plugins/otter-blocks/

GNU General Public License v3.0

133 stars 33 forks source link

fix: resize leaflet maps on resize #2062

Closed HardeepAsrani closed 7 months ago

HardeepAsrani commented 7 months ago

Closes #2053.

Summary

Adds a resizer-observer to Leaflet Maps block to fix an issue with Tabs not rendering Map Block properly.

Test instructions

Add Maps Block to a Tab
Load in frontend and resize the window.

Checklist before the final review

[ ] Included E2E or unit tests for the changes in this PR.
[x] Visual elements are not affected by independent changes.
[x] It is at least compatible with the minimum WordPress version.
[x] It loads additional script in frontend only if it is required.
[x] Does not impact the Core Web Vitals.
[x] In case of deprecation, old blocks are safely migrated.
[x] It is usable in Widgets and FSE.
[x] Copy/Paste is working if the attributes are modified.
[x] PR is following [the best practices]()

pirate-bot commented 7 months ago

Bundle Size Diff

Package	Old Size	New Size	Diff
Animations	237.69 KB	237.69 KB	0 B (0.00%)
Blocks	1.5 MB	1.5 MB	58 B (0.00%)
CSS	91.71 KB	91.71 KB	0 B (0.00%)
Dashboard	362.67 KB	362.67 KB	0 B (0.00%)
Onboarding	152.43 KB	152.43 KB	0 B (0.00%)
Export Import	89.53 KB	89.53 KB	0 B (0.00%)
Pro	354.02 KB	354.02 KB	0 B (0.00%)

pirate-bot commented 7 months ago

Plugin build for 35270add5d3c41978393dfbd221b810906b54f81 is ready :bellhop_bell:!

Download Otter – Page Builder Blocks & Extensions for Gutenberg - Production ~ Development
Download Otter Pro - Production ~ Development
Download Blocks Animation - Production ~ Development
Download Blocks CSS - Production ~ Development
Download Blocks Export Import - Production ~ Development

pirate-bot commented 7 months ago

E2E Tests

Playwright Test Status:

Performance Results

serverResponse: 194.95, firstPaint: 547.3, domContentLoaded: 1518.8, loaded: 1520.85, firstContentfulPaint: 9079.8, firstBlock: 11230.4, type: 49.12, minType: 45.25, maxType: 54.87, typeContainer: 13.25, minTypeContainer: 10.77, maxTypeContainer: 17.64, focus: 60.02, minFocus: 53.64, maxFocus: 72.71, inserterOpen: 22.14, minInserterOpen: 19.93, maxInserterOpen: 25.98, inserterSearch: 5.51, minInserterSearch: 5.13, maxInserterSearch: 6.01, inserterHover: 48.36, minInserterHover: 44.46, maxInserterHover: 54.08, listViewOpen: 138.86, minListViewOpen: 126, maxListViewOpen: 153.18

pirate-bot commented 6 months ago

:tada: This PR is included in version 2.6.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: