fix: hardened escaping inside Pro Form Fields

Codeinwp / otter-blocks

Create beautiful and attracting posts, pages, and landing pages with Gutenberg Blocks and Template Library by Otter.

https://wordpress.org/plugins/otter-blocks/

GNU General Public License v3.0

133 stars 33 forks source link

fix: hardened escaping inside Pro Form Fields #2085

Closed HardeepAsrani closed 6 months ago

HardeepAsrani commented 6 months ago

Closes https://github.com/Codeinwp/otter-internals/issues/153.

Summary

Hardens escaping of attributes in Pro Form fields. The PR also makes use of get_block_wrapper_attributes function for attribute generation for the main div of the block.

Test instructions

Follow testing instructions mentioned in the issue and confirm the issue is mitigated, and features work as normal.

Checklist before the final review

[ ] Included E2E or unit tests for the changes in this PR.
[x] Visual elements are not affected by independent changes.
[x] It is at least compatible with the minimum WordPress version.
[x] It loads additional script in frontend only if it is required.
[x] Does not impact the Core Web Vitals.
[x] In case of deprecation, old blocks are safely migrated.
[x] It is usable in Widgets and FSE.
[x] Copy/Paste is working if the attributes are modified.
[x] PR is following [the best practices]()

pirate-bot commented 6 months ago

Bundle Size Diff

Package	Old Size	New Size	Diff
Animations	237.69 KB	237.69 KB	0 B (0.00%)
Blocks	1.5 MB	1.5 MB	0 B (0.00%)
CSS	91.76 KB	91.76 KB	0 B (0.00%)
Dashboard	198.38 KB	198.38 KB	0 B (0.00%)
Onboarding	152.64 KB	152.64 KB	0 B (0.00%)
Export Import	89.53 KB	89.53 KB	0 B (0.00%)
Pro	354.49 KB	354.49 KB	0 B (0.00%)

pirate-bot commented 6 months ago

Plugin build for 7b4f35ac69e7e5481cccd641e139b46d94c39636 is ready :bellhop_bell:!

Download Otter – Page Builder Blocks & Extensions for Gutenberg - Production ~ Development
Download Otter Pro - Production ~ Development
Download Blocks Animation - Production ~ Development
Download Blocks CSS - Production ~ Development
Download Blocks Export Import - Production ~ Development

pirate-bot commented 6 months ago

E2E Tests

Playwright Test Status:

Performance Results

serverResponse: 198.1, firstPaint: 551.15, domContentLoaded: 1526.5, loaded: 1527.2, firstContentfulPaint: 9055.75, firstBlock: 11193.9, type: 47.9, minType: 43.97, maxType: 50.73, typeContainer: 13.06, minTypeContainer: 11.06, maxTypeContainer: 16.83, focus: 58.02, minFocus: 52.26, maxFocus: 62.5, inserterOpen: 22.69, minInserterOpen: 20.52, maxInserterOpen: 26.01, inserterSearch: 5.48, minInserterSearch: 5.07, maxInserterSearch: 6, inserterHover: 46.23, minInserterHover: 44.1, maxInserterHover: 49.19, listViewOpen: 139.31, minListViewOpen: 127.39, maxListViewOpen: 159.97

pirate-bot commented 6 months ago

:tada: This PR is included in version 2.6.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: