fix: introduce svgSanitize to sanitize SVG

Codeinwp / otter-blocks

Create beautiful and attracting posts, pages, and landing pages with Gutenberg Blocks and Template Library by Otter.

https://wordpress.org/plugins/otter-blocks/

GNU General Public License v3.0

133 stars 33 forks source link

fix: introduce svgSanitize to sanitize SVG #2086

Closed HardeepAsrani closed 6 months ago

HardeepAsrani commented 6 months ago

Closes #152.

Summary

Introduces the SVG Sanitize to sanitize SVG files to prevent XSS attacks.

Test instructions

Make sure SVG uploads work as expected.
Make sure the issue mentioned in the issue is solved.

Checklist before the final review

[ ] Included E2E or unit tests for the changes in this PR.
[x] Visual elements are not affected by independent changes.
[x] It is at least compatible with the minimum WordPress version.
[x] It loads additional script in frontend only if it is required.
[x] Does not impact the Core Web Vitals.
[x] In case of deprecation, old blocks are safely migrated.
[x] It is usable in Widgets and FSE.
[x] Copy/Paste is working if the attributes are modified.
[x] PR is following [the best practices]()

pirate-bot commented 6 months ago

Bundle Size Diff

Package	Old Size	New Size	Diff
Animations	237.69 KB	237.69 KB	0 B (0.00%)
Blocks	1.5 MB	1.5 MB	0 B (0.00%)
CSS	91.76 KB	91.76 KB	0 B (0.00%)
Dashboard	198.38 KB	198.38 KB	0 B (0.00%)
Onboarding	152.64 KB	152.64 KB	0 B (0.00%)
Export Import	89.53 KB	89.53 KB	0 B (0.00%)
Pro	354.49 KB	354.49 KB	0 B (0.00%)

pirate-bot commented 6 months ago

Plugin build for d3e6f6f11a99ecd15b0a0f72360c90c9aff11a21 is ready :bellhop_bell:!

Download Otter – Page Builder Blocks & Extensions for Gutenberg - Production ~ Development
Download Otter Pro - Production ~ Development
Download Blocks Animation - Production ~ Development
Download Blocks CSS - Production ~ Development
Download Blocks Export Import - Production ~ Development

pirate-bot commented 6 months ago

E2E Tests

Playwright Test Status:

Performance Results

serverResponse: 196.4, firstPaint: 549.3, domContentLoaded: 1505.55, loaded: 1506.15, firstContentfulPaint: 8469.85, firstBlock: 10571, type: 47.75, minType: 44.63, maxType: 50.94, typeContainer: 12.58, minTypeContainer: 10.41, maxTypeContainer: 16.55, focus: 58.45, minFocus: 53.53, maxFocus: 66.92, inserterOpen: 21.93, minInserterOpen: 19.72, maxInserterOpen: 25.59, inserterSearch: 5.53, minInserterSearch: 5.13, maxInserterSearch: 6.2, inserterHover: 44.96, minInserterHover: 42.97, maxInserterHover: 48.91, listViewOpen: 135.12, minListViewOpen: 121.8, maxListViewOpen: 148.05

pirate-bot commented 6 months ago

:tada: This PR is included in version 2.6.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: