fix: sanitization of uploaded svg

Codeinwp / otter-blocks

Create beautiful and attracting posts, pages, and landing pages with Gutenberg Blocks and Template Library by Otter.

https://wordpress.org/plugins/otter-blocks/

GNU General Public License v3.0

129 stars 33 forks source link

fix: sanitization of uploaded svg #2166

Closed preda-bogdan closed 2 months ago

preda-bogdan commented 2 months ago

Closes Codeinwp/otter-internals#164.

Summary

Added filter to sanitize SVG before upload.

Screenshots

Test instructions

Follow the steps from the linked issue.

Checklist before the final review

[x] Included E2E or unit tests for the changes in this PR.
[x] Visual elements are not affected by independent changes.
[x] It is at least compatible with the minimum WordPress version.
[x] It loads additional script in frontend only if it is required.
[x] Does not impact the Core Web Vitals.
[x] In case of deprecation, old blocks are safely migrated.
[x] It is usable in Widgets and FSE.
[x] Copy/Paste is working if the attributes are modified.
[x] PR is following [the best practices]()

pirate-bot commented 2 months ago

Bundle Size Diff

Package	Old Size	New Size	Diff
Animations	237.69 KB	237.69 KB	0 B (0.00%)
Blocks	1.5 MB	1.5 MB	0 B (0.00%)
CSS	91.76 KB	91.76 KB	0 B (0.00%)
Dashboard	200.11 KB	200.11 KB	0 B (0.00%)
Onboarding	152.76 KB	152.76 KB	0 B (0.00%)
Export Import	89.53 KB	89.53 KB	0 B (0.00%)
Pro	354.49 KB	354.49 KB	0 B (0.00%)

pirate-bot commented 2 months ago

Plugin build for 19e33fc80c6fbbe4133b2aef2d7e69c08fb416f1 is ready :bellhop_bell:!

Download Otter – Page Builder Blocks & Extensions for Gutenberg - Production ~ Development
Download Otter Pro - Production ~ Development
Download Blocks Animation - Production ~ Development
Download Blocks CSS - Production ~ Development
Download Blocks Export Import - Production ~ Development

pirate-bot commented 2 months ago

E2E Tests

Playwright Test Status:

Performance Results

serverResponse: 215.25, firstPaint: 528.4, domContentLoaded: 1543.75, loaded: 1544.25, firstContentfulPaint: 3558.4, firstBlock: 5435.55, type: 11.65, minType: 10.32, maxType: 13.24, typeContainer: 7.67, minTypeContainer: 6.95, maxTypeContainer: 8.8, focus: 43.69, minFocus: 39.56, maxFocus: 61.08, inserterOpen: 27.17, minInserterOpen: 24.57, maxInserterOpen: 30.04, inserterSearch: 6.79, minInserterSearch: 6.2, maxInserterSearch: 7.92, inserterHover: 3.39, minInserterHover: 2.85, maxInserterHover: 4.82, listViewOpen: 158.2, minListViewOpen: 136.86, maxListViewOpen: 201.96

vytisbulkevicius commented 2 months ago

@preda-bogdan, can you check the conflict here?

preda-bogdan commented 2 months ago

@vytisbulkevicius done!

pirate-bot commented 2 months ago

:tada: This PR is included in version 2.6.9 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: