fix: margin and padding range for section block

Codeinwp / otter-blocks

Create beautiful and attracting posts, pages, and landing pages with Gutenberg Blocks and Template Library by Otter.

https://wordpress.org/plugins/otter-blocks/

GNU General Public License v3.0

129 stars 33 forks source link

fix: margin and padding range for section block #2168

Closed preda-bogdan closed 2 months ago

preda-bogdan commented 2 months ago

Closes #2148.

Summary

Fixed the range control when first adding the section block for the margin and padding. Added e2e test for this behavior.

Screenshots

Test instructions

Add a Section block with one Column
Add a paragraph in that Column
Try to add a Margin or Padding using the slider control, not entering the numeric value
E2E tests should pass

Checklist before the final review

[x] Included E2E or unit tests for the changes in this PR.
[x] Visual elements are not affected by independent changes.
[x] It is at least compatible with the minimum WordPress version.
[x] It loads additional script in frontend only if it is required.
[x] Does not impact the Core Web Vitals.
[x] In case of deprecation, old blocks are safely migrated.
[x] It is usable in Widgets and FSE.
[x] Copy/Paste is working if the attributes are modified.
[x] PR is following [the best practices]()

pirate-bot commented 2 months ago

Bundle Size Diff

Package	Old Size	New Size	Diff
Animations	237.69 KB	239.1 KB	1.42 KB (0.60%)
Blocks	1.5 MB	1.5 MB	2.35 KB (0.15%)
CSS	91.76 KB	93.17 KB	1.42 KB (1.55%)
Dashboard	200.11 KB	201.53 KB	1.42 KB (0.71%)
Onboarding	152.76 KB	154.18 KB	1.42 KB (0.93%)
Export Import	89.53 KB	90.95 KB	1.42 KB (1.58%)
Pro	354.49 KB	355.91 KB	1.42 KB (0.40%)

pirate-bot commented 2 months ago

Plugin build for 755bff875ecf32e5dcc0a9308f446f7ee61f24d7 is ready :bellhop_bell:!

Download Otter – Page Builder Blocks & Extensions for Gutenberg - Production ~ Development
Download Otter Pro - Production ~ Development
Download Blocks Animation - Production ~ Development
Download Blocks CSS - Production ~ Development
Download Blocks Export Import - Production ~ Development

pirate-bot commented 2 months ago

E2E Tests

Playwright Test Status:

Performance Results

serverResponse: 216.85, firstPaint: 551.05, domContentLoaded: 1560.65, loaded: 1561.2, firstContentfulPaint: 3592.6, firstBlock: 5522.85, type: 13.24, minType: 11.74, maxType: 17.42, typeContainer: 8.38, minTypeContainer: 7.32, maxTypeContainer: 10.05, focus: 45.48, minFocus: 39.22, maxFocus: 55.22, inserterOpen: 27.77, minInserterOpen: 24.65, maxInserterOpen: 32.38, inserterSearch: 7.1, minInserterSearch: 6.25, maxInserterSearch: 8.18, inserterHover: 3.47, minInserterHover: 3, maxInserterHover: 4.23, listViewOpen: 161.2, minListViewOpen: 139.57, maxListViewOpen: 211.38

pirate-bot commented 2 months ago

:tada: This PR is included in version 2.6.9 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: