Fix/product review line breaks

Codeinwp / otter-blocks

Create beautiful and attracting posts, pages, and landing pages with Gutenberg Blocks and Template Library by Otter.

https://wordpress.org/plugins/otter-blocks/

GNU General Public License v3.0

129 stars 33 forks source link

Fix/product review line breaks #2173

Closed preda-bogdan closed 2 months ago

preda-bogdan commented 2 months ago

Closes #2162.

Summary

Fixed multiline description for product review while maintaining sanitization. Added e2e test to check for this specific case.

Screenshots

Test instructions

Add a Product Review block
In the Description of the product, add more lines of content
Check the Product Review block on frontend multiline should be preserved

Checklist before the final review

[x] Included E2E or unit tests for the changes in this PR.
[x] Visual elements are not affected by independent changes.
[x] It is at least compatible with the minimum WordPress version.
[x] It loads additional script in frontend only if it is required.
[x] Does not impact the Core Web Vitals.
[x] In case of deprecation, old blocks are safely migrated.
[x] It is usable in Widgets and FSE.
[x] Copy/Paste is working if the attributes are modified.
[x] PR is following [the best practices]()

pirate-bot commented 2 months ago

Bundle Size Diff

Package	Old Size	New Size	Diff
Animations	237.69 KB	237.69 KB	0 B (0.00%)
Blocks	1.5 MB	1.5 MB	0 B (0.00%)
CSS	91.76 KB	91.76 KB	0 B (0.00%)
Dashboard	200.11 KB	200.11 KB	0 B (0.00%)
Onboarding	152.76 KB	152.76 KB	0 B (0.00%)
Export Import	89.53 KB	89.53 KB	0 B (0.00%)
Pro	354.49 KB	354.49 KB	0 B (0.00%)

pirate-bot commented 2 months ago

Plugin build for 57a7d6088f712a166f7bff267acd13a57ff2007e is ready :bellhop_bell:!

Download Otter – Page Builder Blocks & Extensions for Gutenberg - Production ~ Development
Download Otter Pro - Production ~ Development
Download Blocks Animation - Production ~ Development
Download Blocks CSS - Production ~ Development
Download Blocks Export Import - Production ~ Development

pirate-bot commented 2 months ago

E2E Tests

Playwright Test Status:

Performance Results

serverResponse: 222.25, firstPaint: 564.05, domContentLoaded: 1565.25, loaded: 1566, firstContentfulPaint: 3719.85, firstBlock: 5681.05, type: 12.66, minType: 10.75, maxType: 16.79, typeContainer: 9.17, minTypeContainer: 7.58, maxTypeContainer: 11.12, focus: 42.89, minFocus: 35.98, maxFocus: 53.61, inserterOpen: 29.13, minInserterOpen: 24.4, maxInserterOpen: 34.12, inserterSearch: 6.64, minInserterSearch: 6.12, maxInserterSearch: 7.07, inserterHover: 3.4, minInserterHover: 2.85, maxInserterHover: 4.3, listViewOpen: 158.86, minListViewOpen: 138.35, maxListViewOpen: 201.69

pirate-bot commented 2 months ago

:tada: This PR is included in version 2.6.9 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: