Allow a subset of HTML tags for Multiple Choices label rendering

Codeinwp / otter-blocks

Create beautiful and attracting posts, pages, and landing pages with Gutenberg Blocks and Template Library by Otter.

https://wordpress.org/plugins/otter-blocks/

GNU General Public License v3.0

129 stars 33 forks source link

Allow a subset of HTML tags for Multiple Choices label rendering #2185

Closed Soare-Robert-Daniel closed 2 months ago

Soare-Robert-Daniel commented 2 months ago

Closes #2091

Summary

Instead of escaping the HTML, I used the wp_kses to clean and allow only a subset of HTML tags.

Screenshots

Test instructions

Insert a Form and a multiple choices field.
In the field label, select the text and add a link using the native widget.
Check if the link is present in Frontend(Page Preview)

Checklist before the final review

[x] Included E2E or unit tests for the changes in this PR.
[x] Visual elements are not affected by independent changes.
[x] It is at least compatible with the minimum WordPress version.
[x] It loads additional script in frontend only if it is required.
[x] Does not impact the Core Web Vitals.
[x] In case of deprecation, old blocks are safely migrated.
[x] It is usable in Widgets and FSE.
[x] Copy/Paste is working if the attributes are modified.
[x] PR is following [the best practices]()

pirate-bot commented 2 months ago

Bundle Size Diff

Package	Old Size	New Size	Diff
Animations	239.1 KB	239.1 KB	0 B (0.00%)
Blocks	1.5 MB	1.5 MB	0 B (0.00%)
CSS	93.17 KB	93.17 KB	0 B (0.00%)
Dashboard	201.53 KB	201.53 KB	0 B (0.00%)
Onboarding	154.18 KB	154.18 KB	0 B (0.00%)
Export Import	90.95 KB	90.95 KB	0 B (0.00%)
Pro	355.91 KB	355.91 KB	0 B (0.00%)

pirate-bot commented 2 months ago

Plugin build for 123e8e9bf0d6c056f8713bf6c33b930831f5efa6 is ready :bellhop_bell:!

Download Otter – Page Builder Blocks & Extensions for Gutenberg - Production ~ Development
Download Otter Pro - Production ~ Development
Download Blocks Animation - Production ~ Development
Download Blocks CSS - Production ~ Development
Download Blocks Export Import - Production ~ Development

pirate-bot commented 2 months ago

E2E Tests

Playwright Test Status:

Performance Results

serverResponse: 222.85, firstPaint: 552.7, domContentLoaded: 1575.25, loaded: 1575.75, firstContentfulPaint: 3647.2, firstBlock: 5631.25, type: 12.94, minType: 11.52, maxType: 15.87, typeContainer: 8.06, minTypeContainer: 6.86, maxTypeContainer: 10.32, focus: 43.07, minFocus: 39.2, maxFocus: 49.84, inserterOpen: 28.83, minInserterOpen: 26.35, maxInserterOpen: 33.37, inserterSearch: 6.85, minInserterSearch: 6.35, maxInserterSearch: 7.86, inserterHover: 3.55, minInserterHover: 2.92, maxInserterHover: 5.1, listViewOpen: 154.81, minListViewOpen: 137.33, maxListViewOpen: 192.29

pirate-bot commented 2 months ago

:tada: This PR is included in version 2.6.11 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: