Codeinwp / otter-blocks

Create beautiful and attracting posts, pages, and landing pages with Gutenberg Blocks and Template Library by Otter.
https://wordpress.org/plugins/otter-blocks/
GNU General Public License v3.0
128 stars 33 forks source link

Review block generating double schema markup #2230

Open milicavs opened 4 weeks ago

milicavs commented 4 weeks ago

Description

The review block is generating the Product schema markup two times.

Step-by-step reproduction instructions

  1. Go to https://validator.schema.org/
  2. Enter any URL from the Themeisle blog that has the review block added (eg. https://themeisle.com/blog/wp-engine-review-for-wordpress/)
  3. See how the Product item is detected twice

OR

  1. Go to any URL from the Themeisle blog that has the review block added (e.g. https://themeisle.com/blog/wp-engine-review-for-wordpress/).
  2. View the source of the page and look for the Product markup.
  3. You'll see two script tags with the markup one right after the other.

Screenshots, screen recording, code snippet or Help Scout ticket

https://monosnap.com/file/W7ollK5t4wRhW5WIk1EgVJvYeOSp2d

Environment info

https://pastebin.com/yvZ1Q9yQ

Is the issue you are reporting a regression

No

vytisbulkevicius commented 3 weeks ago

I can't replicate this issue on a fresh website with Otter ratings and schema enabled. @Soare-Robert-Daniel, do you think it's an issue coming from Otter or some misconfiguration on themeisle.com blog? [I have limited admin rights on that website]

Soare-Robert-Daniel commented 3 weeks ago

@vytisbulkevicius, I'm not sure. Most of the issues reported on it involve missing schema, but I could not replicate the behaviour.

For the duplicates I think we can put some guards even if we can not reproduce it.