Fix Buton Group Font settings

Codeinwp / otter-blocks

Create beautiful and attracting posts, pages, and landing pages with Gutenberg Blocks and Template Library by Otter.

https://wordpress.org/plugins/otter-blocks/

GNU General Public License v3.0

135 stars 35 forks source link

Fix Buton Group Font settings #2233

Closed Soare-Robert-Daniel closed 2 months ago

Soare-Robert-Daniel commented 3 months ago

Closes https://github.com/Codeinwp/otter-blocks/issues/2163

Summary

Fixed the wrong connection between font properties
Fix the text line height value to be the same as in the Editor
Added an E2E test.

[!NOTE] Be aware of https://github.com/Codeinwp/otter-blocks/issues/2177

Screenshots

Test instructions

Insert a Button Group block
Modify the value in Typography tab
Check if they correspond in the front end.

Checklist before the final review

[x] Included E2E or unit tests for the changes in this PR.
[x] Visual elements are not affected by independent changes.
[x] It is at least compatible with the minimum WordPress version.
[x] It loads additional script in frontend only if it is required.
[x] Does not impact the Core Web Vitals.
[x] In case of deprecation, old blocks are safely migrated.
[x] It is usable in Widgets and FSE.
[x] Copy/Paste is working if the attributes are modified.
[x] PR is following [the best practices]()

pirate-bot commented 3 months ago

Bundle Size Diff

Package	Old Size	New Size	Diff
Animations	239.1 KB	239.1 KB	0 B (0.00%)
Blocks	1.5 MB	1.5 MB	8 B (0.00%)
CSS	93.17 KB	93.17 KB	0 B (0.00%)
Dashboard	201.53 KB	201.53 KB	0 B (0.00%)
Onboarding	154.18 KB	154.18 KB	0 B (0.00%)
Export Import	90.95 KB	90.95 KB	0 B (0.00%)
Pro	355.91 KB	355.91 KB	0 B (0.00%)

pirate-bot commented 3 months ago

Plugin build for 46a2891f357595e71bb2f65c288514fecb57639e is ready :bellhop_bell:!

Download Otter – Page Builder Blocks & Extensions for Gutenberg - Production ~ Development
Download Otter Pro - Production ~ Development
Download Blocks Animation - Production ~ Development
Download Blocks CSS - Production ~ Development
Download Blocks Export Import - Production ~ Development

pirate-bot commented 3 months ago

E2E Tests

Playwright Test Status:

Performance Results

serverResponse: 223.8, firstPaint: 130.15, domContentLoaded: 1594.4, loaded: 1594.95, firstContentfulPaint: 3749.85, firstBlock: 5758.35, type: 13.33, minType: 12.09, maxType: 15.98, typeContainer: 8.51, minTypeContainer: 7.08, maxTypeContainer: 11.4, focus: 43.51, minFocus: 34.31, maxFocus: 56.66, inserterOpen: 27.43, minInserterOpen: 24.99, maxInserterOpen: 33.98, inserterSearch: 6.28, minInserterSearch: 5.9, maxInserterSearch: 6.85, inserterHover: 3.86, minInserterHover: 3.52, maxInserterHover: 4.66, listViewOpen: 149.17, minListViewOpen: 136.7, maxListViewOpen: 169.71

rodica-andronache commented 3 months ago

@Soare-Robert-Daniel tested and everything works well 👍

pirate-bot commented 2 months ago

:tada: This PR is included in version 2.6.13 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: