Closed selul closed 5 years ago
We can only add one category per-block, so it can either be in Otter Blocks tab or Layout tabs.
Fixed.
Fixed.
It's tabbed really, similar to how Elementor is doing, followed their UI pattern in this.
I don't understand it.
Responsiveness Selector is custom, but built using Gutenberg's Popover component. Wanted to list them horizontally but that would make it too filled for some controls, like Padding control, so that's why had to do it like this.
We can make most of Neve layout, some will need custom CSS, like borders and different styles for Services icons.
Advanced blocks by Otter block
with by Otter blocks
under smaller font size and italic style ? Regarding neve template, maybe @rodica-andronache can share this task with someone and build the template in Gutenberg in the close future. Can you help with some guidance in case that is needed?
@radu-themeisle did start working on the Gutenberg template. Can you please check this and see if it helps?
hi! not sure if this is a problem in the core or not, but I saw that unless you click on the column block itself, even though you click on the Add icon inside that block, the new block is added in the previously selected block https://screencast-o-matic.com/watch/cqVXXM3Qwu
@HardeepAsrani, Here's my feedback for the current version:
Warning: long post ahead! 😁
Advanced Columns
These 2 problems seem to be related to Gutenberg or the theme (Neve):
In a column inside the advanced columns, having a background image, when you click the background settings button it look like adding something as the scroll bar starts to shrink looking like the page is growing in length. It seems to reset when you click anywhere in the page but not in the toolbar (this happens an all the buttons, like the responsive setting button for example): https://www.useloom.com/share/9bc101a9b7184f5f9715c2fafef5a09d
The same behavior happens when hovering over the buttons and the tooltip appears, and when clicking on the button: https://www.useloom.com/share/21ec653239fa483a9ad2fd3c53f35fe6
In Advanced Columns, when setting the linked value for padding to 0, unselect the block and then select it again the padding is unlinked with the top and bottom values being empty and left-right back to default (20px). I also tried putting a random value (12px) and the only difference was that the top value was set to 12, everything else was as before (see screenshot): https://www.useloom.com/share/e54e53065b734d25903a09dadd3f8e9f; http://prntscr.com/m7xcja
When setting the linked value for margin to a certain number if you unlink you get the default values (20px), it should give you the value set when it was linked: https://www.useloom.com/share/45f1ad3a26b140a6a1cd100fd3c5c74a
We should add a hover effect for responsive options, right now there's no feedback so users can't understand, visually, if the input works: https://www.useloom.com/share/f53e530b1d574ef0bc128ae19e3606e6
Idea: why not have 3 buttons with the devices instead of a menu, where there is room for it and removing the menu to simplify the interface. Keep the button just for padding/margin.
We can remove the title "Responsiveness Settings" they are pretty self explanatory.
The horizontal and vertical align seems not to work if minimum height is set to "default", we should hide the options when "default" is selected: https://www.useloom.com/share/88575735872140bfbc51b1c162d08e6f
Idea: make the option of vertical alignment at column level. This way you can vertically align each column as you need (e.g. maybe you want to create a cascade effect)
The control slider for content width and custom height "reset" if you exit the toolbar with the controller selected: https://www.useloom.com/share/444fb0cfb7524395952140118ba6cae3
If "custom height" is selected, you input a number and then want to reset it pressing backspace or delete keys don't work, only inputting 0 (seems to be the case for all these type of inputs): https://www.useloom.com/share/eefbd37aff404fa288dad1ecd8b3649a
I don't believe a "reset" button is justified here, users can delete the value and it will revert to the default: http://prntscr.com/m7y1ka
In box shadow we have "Border Shadow" and I believe it should be better called "Shadow Properties" : http://prntscr.com/m7yj7q
There are 2 shape dividers that don't have the "invert" option: curve and clouds
FA Icons
Advanced Heading
Button Group
Sharing Icons
Posts Grid Looks good 😃 One strange thing, the first time I added it the block became invalid (like it happened to iThemes) but after deleting and adding it again I never managed to get an error again. One idea would be that maybe only the first time with a fresh WP the block would error and after that it would work as the info required to display posts is already recorded in the DB (might be a dumb idea but I think it's worth mentioning it.
@HardeepAsrani it would be great if you could add the latest version on git too 👍 it would be easier to test by everyone :D
@HardeepAsrani I did check otter blocks, the advanced column block, and is pretty neat, i think is solid to release it. Meanwhile do you think is possible to do some improvements on those things, but after we release this:
Side question: Do you think we have now the tools, for instance, to build the neve frontpage into the new editor + otter ?