search

Codeinwp / raft

Issues should be created in https://github.com/Codeinwp/otter-blocks
7 stars 2 forks source link

Development #106

Closed HardeepAsrani closed 6 months ago

HardeepAsrani commented 6 months ago
pirate-bot commented 6 months ago

Plugin build for ecc39b2e8c34d8e1a5476bcd16576754f70cc07d is ready :bellhop_bell:!

JohnPixle commented 6 months ago

@HardeepAsrani Thanks for the update, I just tested but need to do some changes:

  1. The copy on the banner is not the final one. It should be this one.
Thanks for downloading Raft Theme 🎉

Extend Raft with our Free Builder
Install our free builder plugin for more blocks, enhanced functionality, and seamless theme setup. Learn more.

[ Download Otter Builder ]
  1. If I remember correctly, we had agreed to remove the Otter logo from the wizard steps, and replace it with Raft's logo. Screenshot 2024-02-06 at 11 03 47 AM

Let me know if you need any help!

HardeepAsrani commented 6 months ago

@JohnPixle I just copied them from Figma so I suppose I picked the wrong one, I've fixed that. I've kept the button text to Install Otter instead of Download, let me know if that's fine.

  1. You need to use the Otter PR to see the logo changes as that code is part of Otter, not Raft.
pirate-bot commented 6 months ago

Plugin build for 086f216eaf226ab98b9b1b6463b6dfc30930b9f9 is ready :bellhop_bell:!

JohnPixle commented 6 months ago

@HardeepAsrani thanks, I got it working.

Just 2 notes:

  1. The Learn more link in the banner should link to the Otter plugin page, not the docs.

  2. In the first step, the Raft logo is a bit huge. Can we set the width to 80px please? In the next steps the logo size is fine.

Everything else is good, thanks for taking care of these.

JohnPixle commented 6 months ago

@HardeepAsrani btw, I noticed that after initiating the wizard, I get some errors. Something to look into, or it is expected due to the PRs?

 Admin area URL: https://arrivesoup.s1-tastewp.com/wp-admin 
 Username: pixle 
 Password: ieR-jg8MRfg

Screenshot 2024-02-06 at 11 49 18 AM

HardeepAsrani commented 6 months ago

Based on the errors, I'm guessing you download Otter Dev build while also having Otter WPorg build installed. :)

HardeepAsrani commented 6 months ago

^ @JohnPixle

JohnPixle commented 6 months ago

@HardeepAsrani sort of.

I am not sure how to bypass that.

 Admin area URL: https://arrivesoup.s1-tastewp.com/wp-admin 
 Username: pixle 
 Password: ieR-jg8MRfg

Screenshot 2024-02-06 at 12 10 56 PM

HardeepAsrani commented 6 months ago

@JohnPixle You can download the production build from the PR instead of dev.

pirate-bot commented 6 months ago

:tada: This PR is included in version 1.1.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: